-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirement Boolean Negation Fix #289
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
- Coverage 91.32% 91.30% -0.03%
==========================================
Files 54 54
Lines 13515 13540 +25
==========================================
+ Hits 12343 12363 +20
- Misses 1172 1177 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just one stylistic nit.
Co-authored-by: Daniel Fremont <[email protected]>
…arnVerify/Scenic into RequirementBooleanNegationFix
Description
Fixes an issue where
not
inside a requirement is not handled correctly.Issue Link
#286
Checklist
pytest
and/or other meansAdditional Notes
N/A