Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement Boolean Negation Fix #289

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Conversation

Eric-Vin
Copy link
Collaborator

Description

Fixes an issue where not inside a requirement is not handled correctly.

Issue Link

#286

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@Eric-Vin Eric-Vin marked this pull request as draft July 10, 2024 13:19
@Eric-Vin Eric-Vin marked this pull request as ready for review July 10, 2024 13:34
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (d7679fb) to head (742f4a7).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   91.32%   91.30%   -0.03%     
==========================================
  Files          54       54              
  Lines       13515    13540      +25     
==========================================
+ Hits        12343    12363      +20     
- Misses       1172     1177       +5     
Files Coverage Δ
src/scenic/core/requirements.py 95.23% <100.00%> (+0.03%) ⬆️
src/scenic/syntax/compiler.py 98.47% <100.00%> (+0.02%) ⬆️

... and 7 files with indirect coverage changes

@Eric-Vin Eric-Vin requested a review from abanuelo July 10, 2024 19:07
Copy link
Collaborator

@abanuelo abanuelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one stylistic nit.

@Eric-Vin Eric-Vin requested a review from dfremont July 11, 2024 10:28
@dfremont dfremont merged commit 652a7ec into main Jul 11, 2024
26 checks passed
@dfremont dfremont deleted the RequirementBooleanNegationFix branch July 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants