Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating Webots examples #263

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented May 9, 2024

Description

This PR aims to clean up the examples/webots folder. Namely, more clarification was added to the README.md on how to run dynamic simulations in Webots.

Pending items: #262 some of the examples are a bit outdated so will wait to hear on the status of what to do with these examples next.

Issue Link

Related to #262

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested a review from Eric-Vin May 9, 2024 21:12
@abanuelo abanuelo assigned dfremont and unassigned dfremont May 9, 2024
@abanuelo abanuelo requested a review from dfremont May 9, 2024 21:12
@abanuelo abanuelo changed the title chore: Updating webots examples chore: Updating Webots examples May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (308c351) to head (95ef877).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   86.19%   86.16%   -0.03%     
==========================================
  Files         144      144              
  Lines       25041    25046       +5     
==========================================
- Hits        21583    21581       -2     
- Misses       3458     3465       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lola831 lola831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the updated instructions and tested them locally. Everything works as expected. The PR is good to merge.

@lola831 lola831 merged commit 9d82eda into main Dec 17, 2024
25 of 26 checks passed
@lola831 lola831 deleted the abanuelo/update-webot-examples branch December 18, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants