Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ci for simulator testing #226

Merged
merged 18 commits into from
Apr 24, 2024
Merged

feat: adding ci for simulator testing #226

merged 18 commits into from
Apr 24, 2024

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented Apr 1, 2024

Description

Adding CI in place to be able to test dynamic scenarios for CARLA and Webots. This CI has been tested privately! In subsequent PRs, dynamic scenarios for CARLA will be built using PyTest. Documentation has also been updated internally for how to get access to the instance running simulator-based tests.

End to End Test Passing with Webots and CARLA dynamic tests changes present on the main branch (ie #227 #231)

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin April 1, 2024 21:34
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.12%. Comparing base (d5a21fc) to head (320b8ef).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   85.89%   86.12%   +0.23%     
==========================================
  Files         144      144              
  Lines       24767    24938     +171     
==========================================
+ Hits        21274    21479     +205     
+ Misses       3493     3459      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abanuelo
Copy link
Contributor Author

abanuelo commented Apr 3, 2024

Note: in order for this workflow to become active in our Scenic repo we need to add all secrets to our repository! I do not have privileges to do so, but happy to collaborate with others to make sure this happens!

@abanuelo abanuelo changed the title feat: adding ci/cd for simulator testing feat: adding ci for simulator testing Apr 12, 2024
@abanuelo abanuelo requested a review from dfremont April 22, 2024 22:10
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As we discussed earlier, if it looks like creating a fresh virtual environment and installing everything into it takes significant time, we could cache one, but let's not worry about that for now.

@abanuelo abanuelo merged commit d846a15 into main Apr 24, 2024
26 checks passed
@dfremont dfremont deleted the abanuelo/aws-ci-poc branch April 24, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants