-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding ci for simulator testing #226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 85.89% 86.12% +0.23%
==========================================
Files 144 144
Lines 24767 24938 +171
==========================================
+ Hits 21274 21479 +205
+ Misses 3493 3459 -34 ☔ View full report in Codecov by Sentry. |
Note: in order for this workflow to become active in our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! As we discussed earlier, if it looks like creating a fresh virtual environment and installing everything into it takes significant time, we could cache one, but let's not worry about that for now.
Description
Adding CI in place to be able to test dynamic scenarios for CARLA and Webots. This CI has been tested privately! In subsequent PRs, dynamic scenarios for CARLA will be built using PyTest. Documentation has also been updated internally for how to get access to the instance running simulator-based tests.
End to End Test Passing with Webots and CARLA dynamic tests changes present on the main branch (ie #227 #231)
Issue Link
Checklist
pytest
and/or other meansAdditional Notes