Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable folia support. #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexvermaning0
Copy link

@alexvermaning0 alexvermaning0 commented Jun 24, 2023

adding this to the plugin.yml enables folia support.

i have done some testing and the plugin works on folia just fine.
image

you can also just do it manually.

@Atticuss26
Copy link

I doubt that's all you'd need to do
image
image

@BenWoodworth
Copy link
Owner

Sorry for the late reply! I missed this issue when it was created.
I'd be a little skeptical that FastCraft would work out of the box multi-threaded. I'm not familiar with Folia or how it works, but I have given multi-threading a shot with FastCraft in the past and ran into trouble. Mainly because crafting items interacts with the world (recipes/permissions differing by world, player stats, etc.), so instead of calculating available items to be crafted on multiple threads, I loaded them gradually doing a certain amount per game tick.

It's been years since I've worked on that code, so things may have changed and I'm definitely rusty, but I'd want more confidence about what Folia does, what needs to be changed, and why other things don't need to (config, player preferences, etc.).

And I suppose more generally, what the impact is of supporting Folia vs. not. (small/big performance increase, not being able to use FastCraft at all on Folia servers without support, is there any maintenance burden when developing FastCraft, etc.)

I'm definitely not informed enough to know these myself, but it's definitely up for discussion :)

@alexvermaning0
Copy link
Author

i have re-done the test with folia. it needs some work. on the newer versions of folia the plugin has issues loading. but on a older version of folia it works pretty well. there is an issue with the wooden planks blocks only listing 2 out of 3 wood types.

here is it running on an older version of folia:
https://github.com/BenWoodworth/FastCraft/assets/17603899/daa0f5f7-49b2-48d0-a73b-6e9f02d35bf0

error log of fastcraft on newer folia: https://pastebin.com/Myxbphbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants