Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user-defined JS Hooks #717

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add support for user-defined JS Hooks #717

wants to merge 12 commits into from

Conversation

APB9785
Copy link
Contributor

@APB9785 APB9785 commented Jan 3, 2025

Resolves #284

@APB9785 APB9785 self-assigned this Jan 3, 2025
@APB9785 APB9785 marked this pull request as ready for review January 7, 2025 17:59
@APB9785 APB9785 requested a review from leandrocp January 7, 2025 17:59
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Just left some minor comments.

guides/recipes/javascript-interoperability.md Outdated Show resolved Hide resolved
lib/beacon/content/js_hook.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more

lib/beacon/runtime_js.ex Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for user-defined client JS hooks
2 participants