-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated environment and Pandana 0.4 compatibility #129
Conversation
Hey @smmaurer- looks like you already caught that # 1 was fixed in master, as was # 2, prior to this PR. |
Hi @theocharides, this is ready to merge! I've added installation instructions, and updated the title and original writeup. My only uncertainty is whether we should still include |
Ok, I've added back the preprocessing to the instructions! There's a bug preventing that from running at the moment, which I'll fix in another PR. But no need to wait on that for merging this one, @theocharides. |
Confirmed that the Conda environment works in Linux (in addition to @smmaurer's Mac testing). Will likely remove the need for a pip install option going forward. |
This PR has several small fixes:
Adds(Already fixed in another PR.)cast = True
inupdate_col_from_series()
, in thehousehold_relocation
step. I was getting an int32/int64 error there.Replaces(Already fixed in another PR.)settings
injectable with newerpolicy
injectable in one spot insummaries.py
-- I was getting an error thatsettings
doesn't exist, because it's no longer passed into that model step. (Everything else in that model step usespolicy
; maybe this line was broken when I was resolving conflicts during the merges I made a couple of months ago?) But @theocharides please confirm that this looks right!Adjusts some Pandana aggregation settings -- it turns out that 'average' was an undocumented alias for 'ave', and 'average' was accidentally removed in Pandana v0.4. Using 'ave' will work with all Pandana versions. See Reinstate alternate names for aggregation types? UDST/pandana#133.
Environments: Updates
requirements-2019.txt
to improve support for Python 2.7.Adds a Conda environment file:
baus-env-2020.yml
. This should be the default now.Updates main README.md with new installation instructions.