Kavitha|Awaiting appointments code refactor #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Kavitha, Umair | A-1204370983916597| add database column and api changes for priority (#104) * add database column and api changes for priority Co-authored-by: Umair Fayaz <[email protected]> * add priority to appointment audit Co-authored-by: Umair Fayaz <[email protected]> * fixed test failure for priority * add tests for code coverage --------- Co-authored-by: Umair Fayaz <[email protected]> * Kavitha | A-1204361352115416 | removed invalid priority and related tests (#106) * removed invalid priority and related tests * added testcase for invalid priority * Backend migration to create dateless appointments (#105) * allow dateless appointments if status is waitlist (#108) * Kavitha, Umair | A-1204370983916597| add database column and api changes for priority (#104) * add database column and api changes for priority * add priority to appointment audit * fixed test failure for priority * add tests for code coverage --------- Co-authored-by: Umair Fayaz <[email protected]> * Kavitha | A-1204361352115416 | removed invalid priority and related tests (#106) * removed invalid priority and related tests * added testcase for invalid priority * Backend migration to create dateless appointments (#105) * allow dateless appointments if status is waitlist (#108) * Add logic to filter DateLess Appointments * add. appointment creation date in response (#109) * Add tests to filter DateLess Appointments * Update POM files * Fix failing Tests for Search appointments * Kavitha | add date check and tests for waitlist appointments * Kavitha | removed Invalid priority * Kavitha | added missed tests from master branch * Kavitha | rename datelessAppointments to appointmentsWithoutDates * Kavitha | add default null value to date columns in appt * Kavitha | removed status check in appointment json * Kavitha | removed sorting based on status * Kavitha | removed unused imports --------- Co-authored-by: Umair Fayaz <[email protected]> Co-authored-by: Phanindra-tw <[email protected]> Co-authored-by: Arjun G <[email protected]>
Arjun-Go
approved these changes
May 8, 2024
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.Set; | ||
| import java.util.*; |
There was a problem hiding this comment.
Can we have specific imports rather than * import
| import org.openmrs.Person; | ||
| import org.openmrs.Provider; | ||
| import org.openmrs.User; | ||
| import org.mockito.*; |
Arjun-Go
added a commit
that referenced
this pull request
May 22, 2024
* BAH-3479 | Backend changes for dateless appointments (#145) * Kavitha, Umair | A-1204370983916597| add database column and api changes for priority (#104) * add database column and api changes for priority Co-authored-by: Umair Fayaz <[email protected]> * add priority to appointment audit Co-authored-by: Umair Fayaz <[email protected]> * fixed test failure for priority * add tests for code coverage --------- Co-authored-by: Umair Fayaz <[email protected]> * Kavitha | A-1204361352115416 | removed invalid priority and related tests (#106) * removed invalid priority and related tests * added testcase for invalid priority * Backend migration to create dateless appointments (#105) * allow dateless appointments if status is waitlist (#108) * Kavitha, Umair | A-1204370983916597| add database column and api changes for priority (#104) * add database column and api changes for priority * add priority to appointment audit * fixed test failure for priority * add tests for code coverage --------- Co-authored-by: Umair Fayaz <[email protected]> * Kavitha | A-1204361352115416 | removed invalid priority and related tests (#106) * removed invalid priority and related tests * added testcase for invalid priority * Backend migration to create dateless appointments (#105) * allow dateless appointments if status is waitlist (#108) * Add logic to filter DateLess Appointments * add. appointment creation date in response (#109) * Add tests to filter DateLess Appointments * Update POM files * Fix failing Tests for Search appointments * Kavitha | add date check and tests for waitlist appointments * Kavitha | removed Invalid priority * Kavitha | added missed tests from master branch * Kavitha | rename datelessAppointments to appointmentsWithoutDates * Kavitha | add default null value to date columns in appt * Kavitha | removed status check in appointment json * Kavitha | removed sorting based on status * Kavitha | removed unused imports --------- Co-authored-by: Umair Fayaz <[email protected]> Co-authored-by: Phanindra-tw <[email protected]> Co-authored-by: Arjun G <[email protected]> * Kavitha | refactor search API for appointments without dates * Kavitha|lowered test coverage ratio * add specific imports --------- Co-authored-by: Umair Fayaz <[email protected]> Co-authored-by: Phanindra-tw <[email protected]> Co-authored-by: Arjun G <[email protected]>
SanoferSameera
pushed a commit
that referenced
this pull request
Jun 4, 2024
* BAH-3350: Appointments: search endpoint stack traces when a patient has more than one identifier of the same time (#142) * Ability to Filter on Appointments with multi-value support for search keys Ability to Filter on Awaiting Appointments with multiple values for same keys * Added test cases to increase branch coverage & set threshold to 0.60 (#152) Added test cases to increase branch coverage & set threshold to 0.60 (#152) * Kavitha|Awaiting appointments code refactor (#151) * BAH-3479 | Backend changes for dateless appointments (#145) * Kavitha, Umair | A-1204370983916597| add database column and api changes for priority (#104) * add database column and api changes for priority Co-authored-by: Umair Fayaz <[email protected]> * add priority to appointment audit Co-authored-by: Umair Fayaz <[email protected]> * fixed test failure for priority * add tests for code coverage --------- Co-authored-by: Umair Fayaz <[email protected]> * Kavitha | A-1204361352115416 | removed invalid priority and related tests (#106) * removed invalid priority and related tests * added testcase for invalid priority * Backend migration to create dateless appointments (#105) * allow dateless appointments if status is waitlist (#108) * Kavitha, Umair | A-1204370983916597| add database column and api changes for priority (#104) * add database column and api changes for priority * add priority to appointment audit * fixed test failure for priority * add tests for code coverage --------- Co-authored-by: Umair Fayaz <[email protected]> * Kavitha | A-1204361352115416 | removed invalid priority and related tests (#106) * removed invalid priority and related tests * added testcase for invalid priority * Backend migration to create dateless appointments (#105) * allow dateless appointments if status is waitlist (#108) * Add logic to filter DateLess Appointments * add. appointment creation date in response (#109) * Add tests to filter DateLess Appointments * Update POM files * Fix failing Tests for Search appointments * Kavitha | add date check and tests for waitlist appointments * Kavitha | removed Invalid priority * Kavitha | added missed tests from master branch * Kavitha | rename datelessAppointments to appointmentsWithoutDates * Kavitha | add default null value to date columns in appt * Kavitha | removed status check in appointment json * Kavitha | removed sorting based on status * Kavitha | removed unused imports --------- Co-authored-by: Umair Fayaz <[email protected]> Co-authored-by: Phanindra-tw <[email protected]> Co-authored-by: Arjun G <[email protected]> * Kavitha | refactor search API for appointments without dates * Kavitha|lowered test coverage ratio * add specific imports --------- Co-authored-by: Umair Fayaz <[email protected]> Co-authored-by: Phanindra-tw <[email protected]> Co-authored-by: Arjun G <[email protected]> * BAH-3860 | repeated imports in tests * BAH-3860 | fix. tests in AppointmentMapper --------- Co-authored-by: Mark Goodrich <[email protected]> Co-authored-by: Umair Fayaz <[email protected]> Co-authored-by: kalai-tw <[email protected]> Co-authored-by: kavitha-sundararajan <[email protected]> Co-authored-by: Umair Fayaz <[email protected]> Co-authored-by: Phanindra-tw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.