Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add id field to finalTemplates in findForApi function #811

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

omar-bear
Copy link
Collaborator

@omar-bear omar-bear commented Jul 16, 2024

Kapture.2024-07-17.at.14.03.44.mp4

Copy link

@@ -134,7 +134,7 @@ export default {

<style>
.bs-templates_container {
max-height: 500px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi on change le max-height ? Tu peux mettre des screens en description de la PR ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fix the double scroll on the add new mail modal in some screen size
the bug is like this

Kapture.2024-07-17.at.13.59.59.mp4

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sur les grands écrans, ça casse rien ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes its good on all types of screen with this

@omar-bear omar-bear merged commit d642863 into develop-clever Jul 17, 2024
6 checks passed
@omar-bear omar-bear deleted the fix-bug-clever branch July 17, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants