Reimplement strtobool for Python 3.12 compatibility (SVRENG-267) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`distutils` was removed in Python 3.12, which means `distutils.util.strtobool` got removed along with it. The guidance from PEP-632--which laid the foundation to deprecate `distutils`--was to reimplement the `strtobool` (or other functions not directly addressed by the text of the PEP. This PR does just that, using CPython 3.11's `distutils` as a reference, and uses the implementation of `strtobool` along with its test to form the basis for the function within a utility module. Additionally, this PR: - Adds Ruff import ordering. This was missed from #66, since the isort-like behavior is only enabled if the `I` set of rules is enabled; here, we simply extend the default set via `lint.extend-select`. - Adds `pytest` as a dev dependency, and adds pytest into the Makefile and GitHub Actions workflows as appropriate. Finally, the version is bumped to 0.8.16, so we can have a clear marker of which version supports Python 3.12. That said, 0.8.15 is still compatible on CLI workers with boardwalkd running 0.8.16. Resolves #67. Backblaze internal tracking: SVRENG-267
The VERSION file is no longer used.
asullivan-blze
added
bug
SpartanBB
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
distutilswas removed in Python 3.12, which meansdistutils.util.strtoboolgot removed along with it. The guidance from PEP-632--which laid the foundation to deprecatedistutils--was to reimplement thestrtobool(or other functions not directly addressed by the text of the PEP.This PR does just that, using CPython 3.11's
distutilsas a reference, and uses the implementation ofstrtoboolalong with its test to form the basis for the function within a utility module.Additionally, this PR:
Iset of rules is enabled; here, we simply extend the default set vialint.extend-select.pytestas a dev dependency, and adds pytest into the Makefile and GitHub Actions workflows as appropriate.Finally, the version is bumped to 0.8.16, so we can have a clear marker of which version supports Python 3.12. That said, 0.8.15 is still compatible on CLI workers with boardwalkd running 0.8.16.
Resolves #67.
Backblaze internal tracking: SVRENG-267
How was this tested?
make test; using theShouldSucceedTestWorkspaceandShouldFailTestWorkspaceagainst the local development server and both test workspaces functioned as they are intended.Checklist