Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: NavigationBar component UI test #34

Merged
merged 2 commits into from
Aug 28, 2024
Merged

test: NavigationBar component UI test #34

merged 2 commits into from
Aug 28, 2024

Conversation

he2e2
Copy link
Contributor

@he2e2 he2e2 commented Aug 27, 2024

Overview

  • next/navigation 훅 mocking -> Next.js 라우터와의 의존성 제거
  • /login, /my 경로에선 내비게이션 바가 렌더링 되지 않아야 하고, 다른 경로에선 내비게이션 바가 렌더링 되는지 확인
  • 각 버튼을 눌렀을 때, 버튼 색이 변하는지 확인
  • 각 버튼을 눌렀을 때, 올바른 경로로 이동하는지 확인

@he2e2 he2e2 added the Test 테스트 관련 label Aug 27, 2024
@he2e2 he2e2 requested a review from cjeongmin August 27, 2024 14:19
@he2e2 he2e2 self-assigned this Aug 27, 2024
@he2e2 he2e2 force-pushed the test/NavigationBar branch from d1d5290 to db4ec2a Compare August 27, 2024 14:50
cjeongmin
cjeongmin previously approved these changes Aug 27, 2024
Copy link
Member

@cjeongmin cjeongmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🔥

@he2e2
Copy link
Contributor Author

he2e2 commented Aug 27, 2024

이 PR도 커밋 이력 수정해서 리뷰 한 번만 더 부탁 드립니다 🙇‍♀️

@he2e2 he2e2 requested a review from cjeongmin August 27, 2024 16:31
Copy link
Member

@cjeongmin cjeongmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👏🏼

@he2e2 he2e2 merged commit 6dc3b15 into dev Aug 28, 2024
4 checks passed
@he2e2 he2e2 deleted the test/NavigationBar branch August 28, 2024 00:05
cjeongmin pushed a commit that referenced this pull request Aug 31, 2024
* test: Add menu activation status testing

* test: Add routing test
cjeongmin pushed a commit that referenced this pull request Aug 31, 2024
* test: Add menu activation status testing

* test: Add routing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test 테스트 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants