Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overseers part 1 #3258

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Overseers part 1 #3258

merged 3 commits into from
Jun 12, 2024

Conversation

Mayegelt
Copy link
Contributor

@Mayegelt Mayegelt commented Jun 11, 2024

Overseers should work. Though might be a bit messy as I cloned the entry rather than linked to it, as I didn't want to catalogue link to both Militia and Solar cats

Had to move a load of stuff up from Milita and Solar in the way of Wargear and Rules to GST. So things like Flakk Armour, Void Armour, some of the vexilia types of stuff, as well as the Legiones Auxilia rules.

Overseers should work. Though might be a bit messy as I cloned the entry rather than linked to it, as I didn't want to catalogue link to both Militia and Solar cats
@Mayegelt Mayegelt requested review from nstephenh and The4D6 June 11, 2024 10:40
A few fixes for Company Command Squad to prevent it from being taken if you include mortificator, praevaen or overseers retinue.
Still needs to have all the other retinues added to that list as you can't have more than 1.
@Mayegelt
Copy link
Contributor Author

Had a little play with the new command squad thing to stop you taking them if you have another retinue in the form of praevian, mortificator or the overseers ones.

@The4D6
Copy link
Collaborator

The4D6 commented Jun 11, 2024

To clarify, the only centurion that should be able to take them is an un-upgraded one (ie one with no legiones consularis upgrade)

So you shouldn't be able to take them if you have any consularis, not just those that give "another" retinue

@Mayegelt
Copy link
Contributor Author

To clarify, the only centurion that should be able to take them is an un-upgraded one (ie one with no legiones consularis upgrade)

So you shouldn't be able to take them if you have any consularis, not just those that give "another" retinue

So initial I thought this myself. However that was while I was under the impression that a Optae was a form of Consul.
However as it is not. It seems like it is just a generic command squad for centurions (as in the unit type, not the consularis selection).
I can easily change it back if it is not though.

@The4D6
Copy link
Collaborator

The4D6 commented Jun 11, 2024

The rule specifically says "Legion Centurion", and as per the boxout "Terminology: Centurions and Consuls" that refers only to a centurion with no Consul upgrade

the only units that are eligible to take a Company command Squad as a retinue are a Legion Centurion (no consuls at all) or the Optae

@Mayegelt
Copy link
Contributor Author

Ok cool. Will revert that change. Though I think it was still allowing it to be taken as other consul types on master I think.

@nstephenh
Copy link
Contributor

Cloning does prevent us from having to worry about any weirdness with provenance specific wargear.

@nstephenh nstephenh mentioned this pull request Jun 11, 2024
14 tasks
Fix for fix for Company Command Squad
Also fix for Blackshields as they were getting Company Command Squads as a root entry for no reason.
Copy link
Contributor

@nstephenh nstephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, there's a couple of changes I don't quite know what there for but I'm good with this.

@@ -16047,182 +16155,882 @@ Special rules that are removed:
</selectionEntry>
</selectionEntries>
</selectionEntryGroup>
</sharedSelectionEntryGroups>
<sharedRules>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change anything about the shared rules or did they just end up getting re-ordered or something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just the diff being extremely confused about a new selection entry group being added....

@nstephenh nstephenh merged commit 4897895 into main Jun 12, 2024
2 checks passed
@nstephenh nstephenh deleted the Overseer branch June 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants