Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logging mentioning retrial to retry. We are not heading to court #2090

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

tiggi
Copy link

@tiggi tiggi commented Jan 30, 2025

While reading logs I got miffed that retrial was used instead of retry.
Fix that in log messages.

The code is still full of variables using retrial and the configuration YAML also contains it.

Related: #2088

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tiggi !

@kinow kinow self-assigned this Jan 30, 2025
@kinow kinow added this to the 4.1.13 milestone Jan 30, 2025
@kinow
Copy link
Member

kinow commented Jan 30, 2025

Allowed PR to run, and assigned 4.1.13 (we can pull to 4.1.12 if we cut a new release for the testing suite, @dbeltrankyl , pretty small change).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.80%. Comparing base (b95b91f) to head (d9f41c9).

Files with missing lines Patch % Lines
autosubmit/platforms/platform.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2090   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files          72       72           
  Lines       17569    17569           
  Branches     3418     3418           
=======================================
  Hits         8751     8751           
  Misses       8007     8007           
  Partials      811      811           
Flag Coverage Δ
fast-tests 49.80% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kinow kinow merged commit 80e6f37 into BSC-ES:master Jan 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants