Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Experiment details background task #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LuiggiTenorioK
Copy link
Member

@LuiggiTenorioK LuiggiTenorioK commented Jan 15, 2025

PR to handle #168

This will leave the details records unchanged when it fails to the the experiment data or the experiment is not existent since the task will not wipe out the table anymore.

@LuiggiTenorioK LuiggiTenorioK self-assigned this Jan 15, 2025
@LuiggiTenorioK LuiggiTenorioK linked an issue Jan 15, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.55%. Comparing base (09028b6) to head (347eb2d).

Files with missing lines Patch % Lines
autosubmit_api/repositories/experiment_details.py 81.25% 3 Missing ⚠️
autosubmit_api/bgtasks/tasks/details_updater.py 93.54% 2 Missing ⚠️
autosubmit_api/workers/populate_details_db.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   75.66%   75.55%   -0.11%     
==========================================
  Files          89       89              
  Lines        7643     7635       -8     
==========================================
- Hits         5783     5769      -14     
- Misses       1860     1866       +6     
Flag Coverage Δ
fast-tests 75.55% <88.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuiggiTenorioK LuiggiTenorioK marked this pull request as ready for review January 27, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update details background task
2 participants