Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor history module db manager #161

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

LuiggiTenorioK
Copy link
Member

@LuiggiTenorioK LuiggiTenorioK commented Dec 17, 2024

PR to replace the usage of sqlite3 lib to favor the repositories.

Tasks:

  • Remove unused methods
  • Add tests to ensure it returns the same content before and after refactoring
  • Replace the calls to the Database Manager with the proper repositories
  • Remove Database Manager and remove db_version check (schema hasn't changed since Autosubmit 3.13.0)

@LuiggiTenorioK LuiggiTenorioK self-assigned this Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.13%. Comparing base (09028b6) to head (663a6fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   75.66%   76.13%   +0.47%     
==========================================
  Files          89       88       -1     
  Lines        7643     7501     -142     
==========================================
- Hits         5783     5711      -72     
+ Misses       1860     1790      -70     
Flag Coverage Δ
fast-tests 76.13% <100.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuiggiTenorioK LuiggiTenorioK force-pushed the refactor-history-module branch from 6449f7d to de70f18 Compare December 19, 2024 12:27
@LuiggiTenorioK LuiggiTenorioK marked this pull request as ready for review December 19, 2024 13:27
@kinow kinow self-requested a review December 25, 2024 08:42
@LuiggiTenorioK LuiggiTenorioK force-pushed the refactor-history-module branch 2 times, most recently from ab8efb8 to d6f302a Compare January 9, 2025 17:08
@LuiggiTenorioK LuiggiTenorioK force-pushed the refactor-history-module branch from d6f302a to 663a6fe Compare January 27, 2025 15:09
@LuiggiTenorioK
Copy link
Member Author

LuiggiTenorioK commented Jan 28, 2025

New TODO:

  • Ensure job_data and experiment_run tables are created

@LuiggiTenorioK
Copy link
Member Author

New TODO:

  • Ensure job_data and experiment_run tables are created

I just remembered that I did test it in a previous PR 🤣

@LuiggiTenorioK LuiggiTenorioK merged commit 1ecab71 into main Jan 30, 2025
9 checks passed
@LuiggiTenorioK LuiggiTenorioK deleted the refactor-history-module branch January 30, 2025 12:01
@LuiggiTenorioK LuiggiTenorioK linked an issue Jan 30, 2025 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize all SQL operations in a repository module
2 participants