Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip docker_wrapper Linux executable #6043

Closed
wants to merge 1 commit into from
Closed

Conversation

davidpanderson
Copy link
Contributor

No description provided.

@AenBleidd
Copy link
Member

We already doing that when building both docker_wrapper for release:

export LDFLAGS="-static-libstdc++ -s"

I suggest not doing that in the Makefile directly to avoid changing it every time when required to build debug version for local testing.

@davidpanderson
Copy link
Contributor Author

OK

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.95%. Comparing base (1e99ff5) to head (2e48dda).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6043      +/-   ##
============================================
- Coverage     11.95%   11.95%   -0.01%     
  Complexity     1068     1068              
============================================
  Files           280      280              
  Lines         36974    36982       +8     
  Branches       8533     8533              
============================================
  Hits           4420     4420              
- Misses        32154    32162       +8     
  Partials        400      400              

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants