Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: on forum page, tell user they have to log in to post #6040

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

davidpanderson
Copy link
Contributor

Currently, if we direct someone to the "Questions and problems" forum,
and they're not logged in, it's a dead end;
they aren't told that they need to log in
(and/or create an account) in order to post a question. Add this.

Currently, if we direct someone to the "Questions and problems" forum,
and they're not logged in, it's a dead end;
they aren't told that they need to log in
(and/or create an account) in order to post a question. Add this.
@AenBleidd AenBleidd requested a review from Copilot January 28, 2025 09:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@AenBleidd AenBleidd requested a review from Copilot January 28, 2025 10:55
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.95%. Comparing base (1e99ff5) to head (e6ef943).
Report is 17 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6040      +/-   ##
============================================
- Coverage     11.95%   11.95%   -0.01%     
  Complexity     1068     1068              
============================================
  Files           280      280              
  Lines         36974    36982       +8     
  Branches       8533     8533              
============================================
  Hits           4420     4420              
- Misses        32154    32162       +8     
  Partials        400      400              

see 4 files with indirect coverage changes

@AenBleidd AenBleidd merged commit 25b8200 into master Jan 28, 2025
154 checks passed
@AenBleidd AenBleidd deleted the dpa_forum_login2 branch January 28, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants