Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][windows] sign executables using Azure #5981

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

AenBleidd
Copy link
Member

No description provided.

@AenBleidd AenBleidd force-pushed the vko_add_new_windows_signing branch 13 times, most recently from 1da07c3 to 3b5c616 Compare December 29, 2024 14:55
@AenBleidd AenBleidd force-pushed the vko_add_new_windows_signing branch from 3b5c616 to 8b1373f Compare December 29, 2024 20:24
@AenBleidd AenBleidd marked this pull request as ready for review December 29, 2024 21:12
@Copilot Copilot bot review requested due to automatic review settings December 29, 2024 21:12
@AenBleidd AenBleidd added this to the Client/Manager 8.0.5 milestone Dec 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • win_build/boinc.sln: Language not supported
  • win_build/boinc_signing.targets: Language not supported
  • win_build/installer.vcxproj: Language not supported
  • win_build/installer_msi.vcxproj: Language not supported
  • win_build/installer_setup.vcxproj: Language not supported
  • ci_tools/trailing_whitespaces_check.py: Evaluated as low risk
Comments suppressed due to low confidence (2)

.github/workflows/windows.yml:42

  • The path uses backslashes which might cause issues. Consider using forward slashes or a method that handles path separators correctly.
TSCT: ${{github.workspace}}\temp\TSCT

.github/workflows/windows.yml:101

  • The condition checks for environment variables using '!= 0' which might be confusing. Consider checking for non-empty strings instead.
if: success() && matrix.type == 'msbuild' && startsWith(github.ref, 'refs/tags/') && env.AZURE_CLIENT_ID != 0 && env.AZURE_CLIENT_SECRET != 0 && env.AZURE_TENANT_ID != 0 && env.AZURE_ENDPOINT != 0 && env.AZURE_CODE_SIGNING_NAME != 0 && env.AZURE_CERT_PROFILE_NAME != 0
@AenBleidd AenBleidd merged commit 1936f9b into master Dec 29, 2024
153 checks passed
@AenBleidd AenBleidd deleted the vko_add_new_windows_signing branch December 29, 2024 21:14
@AenBleidd AenBleidd modified the milestones: Client/Manager 8.0.5, Client/Manager 8.2.0 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

1 participant