Make portable implementation const
#439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
reviewed
Jan 6, 2025
| @@ -120,7 +119,7 @@ pub fn compress_xof( | |||
| crate::platform::le_bytes_from_words_64(&state) | |||
| } | |||
|
|
|||
| pub fn hash1<const N: usize>( | |||
| const fn hash1<const N: usize>( | |||
There was a problem hiding this comment.
Not really, but since there are a few other backends with the same function and in all cases it is internal implementation without pub (here too), I decided to remove it for consistency too. Happy to restore if maintainers have strong opinion on this one.
nazar-pc
commented
Jan 6, 2025
| @@ -120,7 +119,7 @@ pub fn compress_xof( | |||
| crate::platform::le_bytes_from_words_64(&state) | |||
| } | |||
|
|
|||
| pub fn hash1<const N: usize>( | |||
| const fn hash1<const N: usize>( | |||
There was a problem hiding this comment.
Not really, but since there are a few other backends with the same function and in all cases it is internal implementation without pub (here too), I decided to remove it for consistency too. Happy to restore if maintainers have strong opinion on this one.
nazar-pc
force-pushed
the
portable-const
branch
from
b3eb262 to
d80acb3
Compare
|
@oconnor663 it'd be great to get your attention here, especially since the changes are fairly simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to use BLAKE3 in
constenvironment, but it doesn't support such use case yet.This relatively small PR refactors portable implementation to make it work in
constenvironment.There is a bit of trivially verifiable
unsafedue to nicer APIs not yet available inconstenvironment, but these all work on stable.arrayrefwere hard to read and used slicing that is not compatible withconst, so I replaced it with a couple simple macros where it was necessary and left other usages as is.