Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange components for the installer #248

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

NovaRain
Copy link

@NovaRain NovaRain commented Oct 22, 2023

Left - previous, Right - this PR.
rpu_instx

IMO language packs are more important than other optional components, and followed by the three radio button options, then the rest of checkbox options. Come to think of it, maybe add the "fixed" flag to "Ammo damage formula" checkbox? Since it's more like language packs that the main checkbox has no actual use.

@burner1024
Copy link
Member

I think the only 2 important options are language and damage mod, so those should on top.
"Default" damage option is not really necessary, I just couldn't figure out how to make a radio button without having one of its options selected by default.

@NovaRain
Copy link
Author

"Default" damage option is not really necessary, I just couldn't figure out how to make a radio button without having one of its options selected by default.

You mean like this (the left one)?
upui2

@burner1024
Copy link
Member

right

@NovaRain
Copy link
Author

That's easy, since by default DamageFormula is already 0:

// components_ammo.iss
Name: "ammo"; Description: "Ammo damage formula";
Name: "ammo\glovz"; Description: "Glovz's"; Flags: exclusive disablenouninstallwarning;
Name: "ammo\yaam"; Description: "YAAM"; Flags: exclusive disablenouninstallwarning;

// ini_ammo.iss
FileName: "{app}\ddraw.ini"; Section: "Misc"; Key: "DamageFormula"; String: "1"; Components: ammo\glovz;
FileName: "{app}\ddraw.ini"; Section: "Misc"; Key: "DamageFormula"; String: "5"; Components: ammo\yaam;

but personally I'd take the right pic for the sake of uniformity, unless you also want to remove the default English for the language option.

@burner1024
Copy link
Member

ok

@burner1024 burner1024 merged commit 22623ff into BGforgeNet:master Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants