Skip to content

Commit

Permalink
turn on pgo builds
Browse files Browse the repository at this point in the history
  • Loading branch information
patrick-bcw committed Aug 13, 2024
1 parent 4fb67b3 commit a965cb1
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 18 deletions.
30 changes: 15 additions & 15 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:

jobs:
build-pgo:
if: ${{ false }} # disable for now
# if: ${{ false }} # disable for now
name: Build pgo docker image
runs-on: ubuntu-latest
permissions:
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:

deploy-pgo:
name: Deploy pgo-worker to GKE
if: ${{ false }} # disable for now
# if: ${{ false }} # disable for now
runs-on: ubuntu-latest
needs: build-pgo
permissions:
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
run-benchmark:
name: Run benchmarks tests
if: ${{ false }} # disable for now
# if: ${{ false }} # disable for now
runs-on: gha-runner-set
permissions:
contents: 'read'
Expand Down Expand Up @@ -151,11 +151,11 @@ jobs:
MACHINE_TYPE: "t2d-standard-60"
NUM_WORKERS: 1
CPU: 55
MEMORY: 32Gi
BLOCK_START: 801
BLOCK_END: 801
MEMORY: 60Gi
BLOCK_START: 8551
BLOCK_END: 8553
OTHER_ARGS: "pgo.test.run"
RPC_ENDPOINT: "IMX_RPC"
RPC_ENDPOINT: "INTERNAL_RPC"
CPU_THRESHOLD: 1200
run: |-
export USE_GKE_GCLOUD_AUTH_PLUGIN=True
Expand All @@ -169,7 +169,7 @@ jobs:
permissions:
contents: 'read'
id-token: 'write'
# needs: run-benchmark
needs: run-benchmark
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand Down Expand Up @@ -204,11 +204,11 @@ jobs:
- name: Set up Google Cloud SDK
uses: google-github-actions/setup-gcloud@v1

# - name: Pull pgo file from GCS
# run: |-
# mkdir -p ./target/pgo-profiles
# gsutil cp $(gsutil -m ls -l gs://zkevm-csv/profiles | grep $(date -I) | sed 's/.*\(gs:\/\/\)/\1/' | tail -n -1) ./target/pgo-profiles
# ls -lh ./target/pgo-profiles
- name: Pull pgo file from GCS
run: |-
mkdir -p ./pgo-profiles
gsutil cp $(gsutil -m ls -l gs://zkevm-csv/profiles | grep $(date -I) | sed 's/.*\(gs:\/\/\)/\1/' | tail -n -1) ./pgo-profiles
ls -lh ./pgo-profiles
- name: Login to GCR
uses: docker/login-action@v3
Expand All @@ -221,8 +221,8 @@ jobs:
uses: docker/build-push-action@v5
with:
context: .
# file: optimized-worker.Dockerfile
file: Dockerfile
file: optimized-worker.Dockerfile
# file: Dockerfile
push: true
tags: ${{ steps.worker-meta.outputs.tags }}
labels: ${{ steps.worker-meta.outputs.labels }}
Expand Down
2 changes: 0 additions & 2 deletions deploy/helm/zero-bin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ hull:
repository: _HT!us.gcr.io/immutable-418115/{{ (index . "$").Values.hull.config.specific.workerImageName }}
tag: _HT*hull.config.specific.version
imagePullPolicy: Always
command:
- worker
env:
AMQP_URI:
valueFrom:
Expand Down
2 changes: 1 addition & 1 deletion optimized-worker.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ set -eux
cd /src

mkdir -p /artifacts/pgo-profiles
cp -r target/pgo-profiles/* /artifacts/pgo-profiles
cp -r pgo-profiles/* /artifacts/pgo-profiles

# use the cache mount
# (we will not be able to to write to e.g `/src/target` because it is bind-mounted)
Expand Down

0 comments on commit a965cb1

Please sign in to comment.