Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD: update veracode job condition and remove dependency #22

Merged
merged 4 commits into from
Jul 9, 2024
Merged

BUILD: update veracode job condition and remove dependency #22

merged 4 commits into from
Jul 9, 2024

Conversation

breakbotz
Copy link
Contributor

Description

Enabling Veracode's static scan requires three changes:

  1. Setting Veracode API ID and API KEY in GitHub Secrets
  2. Setting the job's condition (in GHA workflow) to run if (PR from dev/ to release/) OR (push into release/) OR (scheduled run)
  3. Remove job's dependency on check_release which never runs on a schedule trigger contradicting veracode's.

@j-ittner j-ittner added this to the 1.0.2 milestone Jul 9, 2024
@j-ittner j-ittner added the build label Jul 9, 2024
@j-ittner j-ittner merged commit 3eead80 into 1.0.x Jul 9, 2024
11 checks passed
@j-ittner j-ittner deleted the build/veracode-scan branch July 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-wong-bcg matthew-wong-bcg matthew-wong-bcg approved these changes

Assignees

@breakbotz breakbotz

Labels
build
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@breakbotz @matthew-wong-bcg @j-ittner