Sensors fatih #12
Sensors fatih #12
Conversation
Displacement_1.pkl
Outdated
There was a problem hiding this comment.
pkl objects should not be commited to the repository unless they were strictly necessary for the program. It is also at the root path, which is not desirable.
|
|
||
|
|
||
| # | ||
|
|
There was a problem hiding this comment.
This part is not necessary, the file should only contain the the class. Seems that the api part it just there for debugging.
There was a problem hiding this comment.
Same as the other pkl
There was a problem hiding this comment.
Why these test cases are not implemented with unittest? It would work well as a test case where you define the temporal files and the runs the assertions.
| import importlib.util | ||
| from pathlib import Path | ||
|
|
||
| class Unpickler: |
There was a problem hiding this comment.
The Unpickler could be added to the utilities folder of the package, better than here in the tests
| ''' Base class for a generator of synthetic data from a model.''' | ||
|
|
||
| """ | ||
| def __init__(self, model_path:str, sensor_positions_path: str, model_parameters: dict, output_parameters: dict = None): |
There was a problem hiding this comment.
Commented test?
| raise NotImplementedError("export_output should be implemented") | ||
|
|
||
| """ | ||
| @staticmethod |
There was a problem hiding this comment.
Delete if not used
| @@ -0,0 +1,122 @@ | |||
| from nibelungenbruecke.scripts.digital_twin_orchestrator.base_model import BaseModel | |||
| #from base_model import BaseModel | |||
There was a problem hiding this comment.
Delete comment
| def GenerateData(self): | ||
| """Generate data based on the model parameters.""" | ||
|
|
||
| self.api_request = API_Request() |
There was a problem hiding this comment.
We will probably have to supply the secretes path for the API key every time we do API_Request().
| translator.translator_to_sensor() | ||
|
|
||
| self.problem.import_sensors_from_metadata(self.model_parameters["MKP_meta_output_path"]) | ||
| self.problem.fields.temperature = self.problem.fields.displacement #!! |
There was a problem hiding this comment.
Why is this? Fenicsxconcrete supports temperature fields. Additionally, displacements are a vector a field and temperature a scalar, they should not be initialized as the same. Temperature is not even needed for this model.
…displacement model
soenmezmehmet
force-pushed
the
sensors_fatih
branch
from
a7f2c74 to
2de6948
Compare
soenmezmehmet
force-pushed
the
master
branch
from
e0e59c1 to
a1e410d
Compare
soenmezmehmet
force-pushed
the
master
branch
from
a1e410d to
d24067e
Compare
soenmezmehmet
force-pushed
the
sensors_fatih
branch
from
2de6948 to
5921c97
Compare
No description provided.