Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove var.http_application_routing_enabled #493

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Remove var.http_application_routing_enabled #493

merged 1 commit into from
Dec 26, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

As #444 described, var.http_application_routing_enabled will be retired on 3 March 2025

All users who are using this addon now please follow the instructions to migrate to a replacement product before 3 March 2025.

We've removed var.http_application_routing_enabled and added aks's http_application_routing_enabled attribute into ignore_changes list, you'll NOT be able to set nor update this config, but this change won't bring you any configuration drift.

Issue number

#444

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

Copy link
Contributor

Potential Breaking Changes in e81294a:
[delete] "Variables.http_application_routing_enabled.Name" from 'http_application_routing_enabled' to ''

Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@jiaweitao001 jiaweitao001 merged commit 7b76e9c into main Dec 26, 2023
4 checks passed
@lonegunmanb lonegunmanb deleted the e-444 branch December 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants