-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore deprecated attribute public_network_access_enabled
#485
Ignore deprecated attribute public_network_access_enabled
#485
Conversation
This pr should solve #400. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ishuar for opening this pr! According to our previous discussion, would you please add public_network_access_enabled
to azurerm_kubernetes_cluster
's ignore_changes
? Thanks!
Potential Breaking Changes in 8be7910: |
Just to confirm, only need to add in ignore_changes but still keep the attribute and variable definition? |
Confirmed, thanks! |
8be7910
to
8d9cf0e
Compare
public_network_access_enabled
public_network_access_enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ishuar, LGTM!
Describe your changes
public_network_access_enabled
Issue number
N/A
Checklist before requesting a review
CHANGELOG.md
fileThanks for your cooperation!