test: Eviction E2E #996
Open
test: Eviction E2E #996
+1,388
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
force-pushed
the
rolloutEvictionE2E
branch
from
4ff6b3b to
028709b
Compare
|
Addressed comment from #959 (comment) |
Arvindthiru
force-pushed
the
rolloutEvictionE2E
branch
2 times, most recently
from
70f5a4f to
bbb380e
Compare
|
|
||
| It("should ensure no resources exist on evicted member cluster with taint", func() { | ||
| taintClusters := buildClustersFromNames(taintClusterNames) | ||
| for _, cluster := range taintClusters { |
There was a problem hiding this comment.
there is only one cluster in the taint list, why using a loop? Should we taint two clusters?
There was a problem hiding this comment.
buildClustersFromNames is a util function that takes in a list if cluster names and returns the list of E2E cluster objects. Hence we need to iterate through the list. In this file we only taint one cluster but we taint multiple clusters here for reference
fleet/test/e2e/taint_toleration_test.go
Line 66 in bbb380e
test/e2e/placement_eviction_test.go
Outdated
| It("should still place resources on the all available member clusters", checkIfPlacedWorkResourcesOnAllMemberClusters) | ||
| }) | ||
|
|
||
| var _ = Describe("ClusterResourcePlacement eviction of bound binding - PickAll CRP, PDB specified to protect resources on all clusters, eviction denied", Ordered, func() { |
There was a problem hiding this comment.
is there a pickFixed case? Is there a pickAll but PDB specified maxUnavailabe case?
Arvindthiru
force-pushed
the
rolloutEvictionE2E
branch
from
bbb380e to
e104b7d
Compare
Arvindthiru
force-pushed
the
rolloutEvictionE2E
branch
from
e104b7d to
5abf54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer