Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of HPA template #398

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Creation of HPA template #398

merged 10 commits into from
Oct 15, 2024

Conversation

Vidya2606
Copy link
Contributor

Description

Create new HPA template

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Tatsinnit
Tatsinnit approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍❤️ looks good to me. Thank you for kind ping!!

@Tatsinnit Tatsinnit added the enhancement New feature or request label Oct 14, 2024
bosesuneha
bosesuneha reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@bosesuneha bosesuneha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bfoley13 bfoley13 merged commit b2e15d9 into Azure:main Oct 15, 2024
149 checks passed
Vidya2606 added a commit to Vidya2606/draft that referenced this pull request Oct 18, 2024
@Vidya2606 @bfoley13
Creation of HPA template (Azure#398)
13866e3 
Co-authored-by: Brandon Foley <[email protected]>
Co-authored-by: Brandon Foley <[email protected]>
@bfoley13 bfoley13 mentioned this pull request Oct 22, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverMKing OliverMKing OliverMKing left review comments

@bosesuneha bosesuneha bosesuneha approved these changes

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@bfoley13 bfoley13 bfoley13 approved these changes

Assignees

@Vidya2606 Vidya2606

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vidya2606 @bfoley13 @Tatsinnit @OliverMKing @bosesuneha