Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
bfoley13 committed Oct 17, 2024
1 parent f48087c commit 194b05a
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 14 deletions.
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ go-generate:
rm -r ./pkg/deployments/deployTypes; \
rm -r ./pkg/workflows/workflows; \
rm -r ./pkg/addons/addons; \
GO111MODULE=on go generate ./pkg/languages/...; \
GO111MODULE=on go generate ./pkg/deployments/...; \
GO111MODULE=on go generate ./pkg/workflows/...; \
GO111MODULE=on go generate ./pkg/addons/...;

.PHONY: test
test: run-unit-tests run-e2e-tests-local
Expand Down
2 changes: 0 additions & 2 deletions cmd/update.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package cmd

import (
"embed"
"encoding/json"
"errors"
"fmt"
Expand All @@ -22,7 +21,6 @@ type updateCmd struct {
dest string
flagVariables []string
templateWriter templatewriter.TemplateWriter
addonFS embed.FS
templateVariableRecorder config.TemplateVariableRecorder
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/templatewriter/writers/filemapwriter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
func TestCopyDirToFileMap(t *testing.T) {

templatewriter := &FileMapWriter{}
err := osutil.CopyDir(template.Addons, "addons/azure/webapp_routing", "/test/dir", &config.DraftConfig{
err := osutil.CopyDir(template.Templates, "addons/azure/webapp_routing", "/test/dir", &config.DraftConfig{
Variables: []*config.BuilderVar{
{
Name: "ingress-tls-cert-keyvault-uri",
Expand Down
8 changes: 0 additions & 8 deletions template/addons.go

This file was deleted.

7 changes: 7 additions & 0 deletions template/addons/azure/webapp_routing/draft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,24 @@ variables:
- name: "service-name"
type: "string"
kind: "kubernetesResourceName"
default:
disablePrompt: true
value: "service"
description: "specify the name of the service this points to"
versions: ">=0.0.1"
- name: "service-namespace"
type: "string"
kind: "kubernetesNamespace"
default:
disablePrompt: true
value: "namespace"
description: "specify the namespace for the ingress"
versions: ">=0.0.1"
- name: "service-port"
type: "int"
kind: "port"
default:
disablePrompt: true
value: 80
description: "the port exposed in the service"
versions: ">=0.0.1"
Expand Down

0 comments on commit 194b05a

Please sign in to comment.