Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed test for System-Assigned Identity output #4112

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion avm/res/api-management/service/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ output resourceId string = service.id
output resourceGroupName string = resourceGroup().name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = service.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = service.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = service.location
Expand Down
4 changes: 2 additions & 2 deletions avm/res/api-management/service/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.6",
"version": "0.7",
"pathFilters": [
"./main.json"
]
}
}
2 changes: 1 addition & 1 deletion avm/res/app/container-app/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ output resourceGroupName string = resourceGroup().name
output name string = containerApp.name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = containerApp.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = containerApp.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = containerApp.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/app/container-app/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.11",
"version": "0.12",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/app/job/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ output location string = job.location
@metadata({
example: '00000000-0000-0000-0000-000000000000'
})
output systemAssignedMIPrincipalId string = job.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = job.?identity.?principalId

// =============== //
// Definitions //
Expand Down
2 changes: 1 addition & 1 deletion avm/res/app/job/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.5",
"version": "0.6",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/app/managed-environment/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ output name string = managedEnvironment.name
output resourceId string = managedEnvironment.id

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = managedEnvironment.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = managedEnvironment.?identity.?principalId

@description('The Default domain of the Managed Environment.')
output defaultDomain string = managedEnvironment.properties.defaultDomain
Expand Down
2 changes: 1 addition & 1 deletion avm/res/app/managed-environment/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.8",
"version": "0.9",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/batch/batch-account/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ output resourceGroupName string = resourceGroup().name
output location string = batchAccount.location

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = batchAccount.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = batchAccount.?identity.?principalId

@description('The private endpoints of the batch account.')
output privateEndpoints array = [
Expand Down
2 changes: 1 addition & 1 deletion avm/res/batch/batch-account/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.9",
"version": "0.10",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/cache/redis/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ output sslPort int = redis.properties.sslPort
output subnetResourceId string = !empty(subnetResourceId) ? redis.properties.subnetId : ''

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = redis.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = redis.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = redis.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/cache/redis/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.8",
"version": "0.9",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/cdn/profile/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ output endpointId string = !empty(endpointProperties) ? profile_endpoint.outputs
output uri string = !empty(endpointProperties) ? profile_endpoint.outputs.uri : ''

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = profile.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = profile.?identity.?principalId

@description('The list of records required for custom domains validation.')
output dnsValidation dnsValidationType[] = [
Expand Down
4 changes: 2 additions & 2 deletions avm/res/cdn/profile/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.11",
"version": "0.12",
"pathFilters": [
"./main.json"
]
}
}
2 changes: 1 addition & 1 deletion avm/res/communication/communication-service/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ output resourceGroupName string = resourceGroup().name
output location string = communicationService.location

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = communicationService.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = communicationService.?identity.?principalId

// ================ //
// Definitions //
Expand Down
2 changes: 1 addition & 1 deletion avm/res/communication/communication-service/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.2",
"version": "0.3",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/compute/disk-encryption-set/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ output name string = diskEncryptionSet.name
output resourceGroupName string = resourceGroup().name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = diskEncryptionSet.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = diskEncryptionSet.?identity.?principalId

@description('The idenities of the disk encryption set.')
output identities object = diskEncryptionSet.identity
Expand Down
2 changes: 1 addition & 1 deletion avm/res/compute/disk-encryption-set/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.3",
"version": "0.4",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/compute/virtual-machine-scale-set/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ output resourceGroupName string = resourceGroup().name
output name string = vmss.name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = vmss.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = vmss.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = vmss.location
Expand Down
4 changes: 2 additions & 2 deletions avm/res/compute/virtual-machine-scale-set/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.5",
"version": "0.6",
"pathFilters": [
"./main.json"
]
}
}
2 changes: 1 addition & 1 deletion avm/res/compute/virtual-machine/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ output resourceId string = vm.id
output resourceGroupName string = resourceGroup().name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = vm.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = vm.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = vm.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/compute/virtual-machine/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.11",
"version": "0.12",
"pathFilters": [
"./main.json"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ output resourceGroupName string = resourceGroup().name
output resourceId string = credentialSet.id

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = credentialSet.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = credentialSet.?identity.?principalId

// =============== //
// Definitions //
Expand Down
2 changes: 1 addition & 1 deletion avm/res/container-registry/registry/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ output resourceGroupName string = resourceGroup().name
output resourceId string = registry.id

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = registry.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = registry.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = registry.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/container-registry/registry/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.6",
"version": "0.7",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/container-service/managed-cluster/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,7 @@ output controlPlaneFQDN string = enablePrivateCluster
: managedCluster.properties.fqdn

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = managedCluster.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = managedCluster.?identity.?principalId

@description('The Client ID of the AKS identity.')
output kubeletIdentityClientId string = managedCluster.properties.?identityProfile.?kubeletidentity.?clientId ?? ''
Expand Down
4 changes: 2 additions & 2 deletions avm/res/container-service/managed-cluster/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.5",
"version": "0.6",
"pathFilters": [
"./main.json"
]
}
}
2 changes: 1 addition & 1 deletion avm/res/data-factory/factory/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ output resourceId string = dataFactory.id
output resourceGroupName string = resourceGroup().name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = dataFactory.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = dataFactory.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = dataFactory.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/data-factory/factory/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.8",
"version": "0.9",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/data-protection/backup-vault/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ output resourceGroupName string = resourceGroup().name
output name string = backupVault.name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = backupVault.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = backupVault.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = backupVault.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/data-protection/backup-vault/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.7",
"version": "0.8",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/databricks/access-connector/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ output resourceId string = accessConnector.id
output resourceGroupName string = resourceGroup().name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = accessConnector.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = accessConnector.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = accessConnector.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/databricks/access-connector/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.3",
"version": "0.4",
"pathFilters": [
"./main.json"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ output name string = endpoint.name

@description('The principal ID of the system assigned identity. Note: As of 2024-03 is not exported by API.')
#disable-next-line BCP187
output systemAssignedMIPrincipalId string = endpoint.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = endpoint.?identity.?principalId

// =============== //
// Definitions //
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ output name string = endpoint.name

@description('The principal ID of the system assigned identity. Note: As of 2024-03 is not exported by API.')
#disable-next-line BCP187
output systemAssignedMIPrincipalId string = endpoint.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = endpoint.?identity.?principalId

// =============== //
// Definitions //
Expand Down
2 changes: 1 addition & 1 deletion avm/res/digital-twins/digital-twins-instance/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ output hostname string = digitalTwinsInstance.properties.hostName
output location string = digitalTwinsInstance.location

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = digitalTwinsInstance.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = digitalTwinsInstance.?identity.?principalId

// =============== //
// Definitions //
Expand Down
4 changes: 2 additions & 2 deletions avm/res/digital-twins/digital-twins-instance/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.1",
"version": "0.2",
"pathFilters": [
"./main.json"
]
}
}
2 changes: 1 addition & 1 deletion avm/res/document-db/database-account/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ output resourceId string = databaseAccount.id
output resourceGroupName string = resourceGroup().name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = databaseAccount.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = databaseAccount.?identity.?principalId

@description('The location the resource was deployed into.')
output location string = databaseAccount.location
Expand Down
2 changes: 1 addition & 1 deletion avm/res/document-db/database-account/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.10",
"version": "0.11",
"pathFilters": [
"./main.json"
]
Expand Down
4 changes: 2 additions & 2 deletions avm/res/elastic-san/elastic-san/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.1",
"version": "0.2",
"pathFilters": [
"./main.json"
]
}
}
2 changes: 1 addition & 1 deletion avm/res/elastic-san/elastic-san/volume-group/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ output location string = location
output resourceGroupName string = resourceGroup().name

@sys.description('The principal ID of the system assigned identity of the deployed Elastic SAN Volume Group.')
output systemAssignedMIPrincipalId string = volumeGroup.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = volumeGroup.?identity.?principalId

@sys.description('Details on the deployed Elastic SAN Volumes.')
output volumes volumeOutputType[] = [
Expand Down
2 changes: 1 addition & 1 deletion avm/res/event-grid/domain/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ output resourceGroupName string = resourceGroup().name
output location string = domain.location

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = domain.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = domain.?identity.?principalId

@description('The private endpoints of the event grid domain.')
output privateEndpoints array = [
Expand Down
2 changes: 1 addition & 1 deletion avm/res/event-grid/domain/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.6",
"version": "0.7",
"pathFilters": [
"./main.json"
]
Expand Down
2 changes: 1 addition & 1 deletion avm/res/event-grid/namespace/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ output location string = namespace.location
output resourceGroupName string = resourceGroup().name

@description('The principal ID of the system assigned identity.')
output systemAssignedMIPrincipalId string = namespace.?identity.?principalId ?? ''
output systemAssignedMIPrincipalId string? = namespace.?identity.?principalId

@sys.description('The Resources IDs of the EventGrid Namespace Topics.')
output topicResourceIds array = [
Expand Down
Loading
Loading