-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strong consistency check for data on disk #1604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhansa-msft
requested review from
souravgupta-msft,
ashruti-msft,
syeleti-msft and
jainakanksha-msft
as code owners
January 6, 2025 09:18
syeleti-msft
reviewed
Jan 9, 2025
@vibhansa-msft Please add the whole use case to validate the scenario also add the correct links in the PR. |
ashruti-msft
approved these changes
Jan 15, 2025
@vibhansa-msft , Do we need to update any public documentation for this new argument? |
jainakanksha-msft
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What
Data being downloaded by block-cache is saved to local disk, if user choses to enable persistence. This feature is useful if application is reading the same files multiple times and we do not have enough in memory cache to hold all of them. When a block is downloaded it's saved on local disk. There are chances of accidental overwrite on the disk file which might corrupt the data. Later when same block is read by application Blobfuse will load the data from this disk file and end up serving corrupt data to user application.
Having a CRC check on the data when it was downloaded, protects us from those accidental corruptions.
🤔 Why
To provide strong data consistency checks and protect data persisted on local disk.
👩🔬 How to validate if applicable
If user choses to persist the downloaded content then this additional flag can provide and extra layer of security.
🔖 Related links
NA