Added statfs for block-cache #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashruti-msft
requested review from
vibhansa-msft,
souravgupta-msft and
syeleti-msft
as code owners
|
@ashruti-msft Please add the output in the PR description and details of the change. |
|
@vibhansa-msft |
@jainakanksha-msft I have added the output please have a look |
vibhansa-msft
approved these changes
Nov 22, 2024
syeleti-msft
approved these changes
Jan 14, 2025
vibhansa-msft
approved these changes
Jan 15, 2025
jainakanksha-msft
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added statfs for block_cache which will show the memory available if disk is not configured otherwise the disk space. Added corresponding tests for this and fixed a few unit changes in file_cache.
Used a VM with an attached disk of size 5G for the follwoing outputs:
When file cache/block cache uses the attached disk for disk caching
When config has block_cache component without disk cache it will show the memory available:
Output when file cache/block cache uses the same VM as disk cache
