Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Set(object) API from MutableJsonElement #38266

Merged
merged 15 commits into from
Aug 22, 2023
Merged

Remove Set(object) API from MutableJsonElement #38266

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a5d274f
Initial reworking
annelo-msft Aug 17, 2023
e76c8dd
Move static method to MJE
annelo-msft Aug 17, 2023
a21c3fa
Some exceptions
annelo-msft Aug 17, 2023
6183720
more exceptions
annelo-msft Aug 17, 2023
a54d2be
nit
annelo-msft Aug 17, 2023
1871d42
add back number tests
annelo-msft Aug 17, 2023
629602c
Update WriteTo
annelo-msft Aug 17, 2023
31d034f
update
annelo-msft Aug 17, 2023
df1c79c
Updates
annelo-msft Aug 17, 2023
e3d95e6
Tests
annelo-msft Aug 17, 2023
c3768f1
Updates
annelo-msft Aug 17, 2023
725051f
Skip test while investigating writer behavior
annelo-msft Aug 17, 2023
5d6b86e
Merge remote-tracking branch 'upstream/main' into core-mdoc-limit-set…
annelo-msft Aug 22, 2023
23cf570
Respect serializer options for changes where needed
annelo-msft Aug 22, 2023
b033268
pr fb
annelo-msft Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions sdk/core/Azure.Core/src/DynamicData/MutableJsonElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,7 @@ public bool TryGetDateTime(out DateTime value)
return true;
case DateTimeOffset:
case string:
SerializeToJsonElement(change.Value, _root.SerializerOptions).TryGetDateTime(out value);
return true;
return SerializeToJsonElement(change.Value, _root.SerializerOptions).TryGetDateTime(out value);
annelo-msft marked this conversation as resolved.
Show resolved Hide resolved
case JsonElement element:
return element.TryGetDateTime(out value);
case null:
Expand Down Expand Up @@ -530,8 +529,7 @@ public bool TryGetDateTimeOffset(out DateTimeOffset value)
return true;
case DateTime:
case string:
SerializeToJsonElement(change.Value, _root.SerializerOptions).TryGetDateTimeOffset(out value);
return true;
return SerializeToJsonElement(change.Value, _root.SerializerOptions).TryGetDateTimeOffset(out value);
case JsonElement element:
return element.TryGetDateTimeOffset(out value);
case null:
Expand Down Expand Up @@ -606,8 +604,7 @@ public bool TryGetGuid(out Guid value)
value = g;
return true;
case string:
SerializeToJsonElement(change.Value, _root.SerializerOptions).TryGetGuid(out value);
return true;
return SerializeToJsonElement(change.Value, _root.SerializerOptions).TryGetGuid(out value);
case JsonElement element:
return element.TryGetGuid(out value);
case null:
Expand Down