Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support token credential cache for azure-identity-extension #43659

Merged
merged 16 commits into from
Jan 8, 2025
Merged

Support token credential cache for azure-identity-extension #43659

merged 16 commits into from
Jan 8, 2025

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Jan 2, 2025 •
edited
Loading

Description

Fixes #39393

Support cache for azure-identity-extension, we target one level cache object, the token credential, enabled by default, user can disable the cache by setting azure.tokenCredentialCacheEnabled=false.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Jan 2, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@moarychan moarychan marked this pull request as ready for review January 6, 2025 00:55
rujche
rujche approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@rujche rujche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@moarychan moarychan mentioned this pull request Jan 7, 2025
Merged
6 tasks
@moarychan moarychan enabled auto-merge (squash) January 8, 2025 01:35
@moarychan moarychan merged commit 2cbcdf6 into Azure:main Jan 8, 2025
18 checks passed
@moarychan moarychan changed the title Support cache for azure-identity-extension Support token credential cache for azure-identity-extension Jan 8, 2025
@moarychan moarychan mentioned this pull request Jan 8, 2025
Open
3 tasks
@pdefreitas pdefreitas mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billwert billwert billwert left review comments

@rujche rujche rujche approved these changes

@saragluna saragluna saragluna approved these changes

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] azure-identity-extensions for PostgreSQL is inneficient
5 participants
@moarychan @azure-sdk @billwert @saragluna @rujche