-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientcore, PagedIterable / PagedResponse / PagingOptions #43484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedResponse.java
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
weidongxu-microsoft
changed the title
[draft] add a simple PagedIterable / PagedResponse
[draft] a simple PagedIterable / PagedResponse
Dec 19, 2024
XiaofeiCao
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for nextLink
.
srnagar
reviewed
Jan 6, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedResponse.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedResponse.java
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
force-pushed
the
clientcore-paged
branch
from
January 7, 2025 03:48
d7e8c4e
to
158a373
Compare
weidongxu-microsoft
force-pushed
the
clientcore-paged
branch
from
January 7, 2025 06:38
cc22d4f
to
ba1e18e
Compare
6 tasks
weidongxu-microsoft
changed the title
[draft] a simple PagedIterable / PagedResponse
clientcore, PagedIterable / PagedResponse
Jan 9, 2025
weidongxu-microsoft
changed the title
clientcore, PagedIterable / PagedResponse
clientcore, PagedIterable / PagedResponse / PagingOptions
Jan 9, 2025
weidongxu-microsoft
requested review from
samvaity,
vcolin7 and
JonathanGiles
as code owners
January 9, 2025 08:15
srnagar
approved these changes
Jan 9, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/PagedIterable.java
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
Jan 20, 2025
depends on Azure/azure-sdk-for-java#43484 and release of clientcore beta.2 back to draft: there is lots of changes to clientcore right now test 827f4ec code is scattered as there is multiple commits to adapt core changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
design https://gist.github.com/srnagar/e9373153593920dcf1977c928c59e988
code in impl would be like
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines