Feature/update tag name for dups #401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ohadbitt
reviewed
Sep 19, 2024
connector/src/main/scala/com/microsoft/kusto/spark/datasink/KustoWriter.scala
Outdated
Show resolved
Hide resolved
| blobUUID: String, | ||
| kustoClient: ExtendedKustoClient, | ||
| partitionsResults: CollectionAccumulator[PartitionResult], | ||
| batchIdForTracing: String, |
There was a problem hiding this comment.
use the batchIdForTracing as well in getDedupTagsPrefix - so that it will work on (spark) streaming as well.
| parameters: KustoWriteResource, | ||
| ingestionProperties: IngestionProperties, | ||
| flushImmediately: Boolean = false, | ||
| blobUUID: String, |
| val kustoClient = KustoClientCache.getClient( | ||
| parameters.coordinates.clusterUrl, | ||
| parameters.authentication, | ||
| parameters.coordinates.ingestionUrl, | ||
| parameters.coordinates.clusterAlias) | ||
| val blobIdMap = new ConcurrentHashMap[String, Int]() |
There was a problem hiding this comment.
did you mean for this to be some static cache ? if so it will need to live outside the function as a member.
currently this will always hold only the current run with the same request id in all Map entries,
Regardless - a simple integer with ncrements would do the job i think
…stoWriter.scala Co-authored-by: ohad bitton <[email protected]>
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
* Update POM
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
* Update POM
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.