-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kcsb refactor #409
kcsb refactor #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- data/src/main/resources/kcsb.json: Language not supported
Comments suppressed due to low confidence (2)
data/src/main/java/com/microsoft/azure/kusto/data/auth/KcsbKeywords.java:72
- The error message could be more informative by suggesting possible valid keywords.
throw new IllegalArgumentException("Keyword `" + keyword + "` is not a known keyword");
data/src/main/java/com/microsoft/azure/kusto/data/auth/ConnectionStringBuilder.java:172
- Ensure that all secret fields are correctly masked with SECRET_REPLACEMENT in the toString method.
sb.append(entry.getLeft().name()).append("=").append(!showSecrets && entry.getLeft().isSecret() ? SECRET_REPLACEMENT : entry.getRight()).append(";");
data/src/main/java/com/microsoft/azure/kusto/data/auth/KcsbKeywords.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/auth/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
…se and cert keywords. - Added version field to kcsb.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- data/src/main/resources/kcsb.json: Language not supported
- data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java: Evaluated as low risk
- data/src/main/java/com/microsoft/azure/kusto/data/auth/ConnectionStringBuilder.java: Evaluated as low risk
- data/src/main/java/com/microsoft/azure/kusto/data/auth/KcsbKeywords.java: Evaluated as low risk
- data/src/main/java/com/microsoft/azure/kusto/data/auth/KnownKeywords.java: Evaluated as low risk
Aligns KCSB parsing with the new method - having a json file that defines keywords and aliases.
Also adds: