Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcsb refactor #409

Merged
merged 18 commits into from
Jan 27, 2025
Merged

kcsb refactor #409

merged 18 commits into from
Jan 27, 2025

Conversation

AsafMah
Copy link
Contributor

@AsafMah AsafMah commented Jan 9, 2025

Aligns KCSB parsing with the new method - having a json file that defines keywords and aliases.

Also adds:

  • ToString() methods for KCSB to align with other sdks
  • Keyword parsing that is case and space insensitive
  • Added keyword for certificate blob, but until we figure it out it just throws for now

Copy link

github-actions bot commented Jan 9, 2025

Test Results

332 tests  +3   323 ✅ +3   3m 17s ⏱️ -8s
 27 suites ±0     9 💤 ±0 
 27 files   ±0     0 ❌ ±0 

Results for commit 973141c. ± Comparison against base commit 3e35cb0.

♻️ This comment has been updated with latest results.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • data/src/main/resources/kcsb.json: Language not supported
Comments suppressed due to low confidence (2)

data/src/main/java/com/microsoft/azure/kusto/data/auth/KcsbKeywords.java:72

  • The error message could be more informative by suggesting possible valid keywords.
throw new IllegalArgumentException("Keyword `" + keyword + "` is not a known keyword");

data/src/main/java/com/microsoft/azure/kusto/data/auth/ConnectionStringBuilder.java:172

  • Ensure that all secret fields are correctly masked with SECRET_REPLACEMENT in the toString method.
sb.append(entry.getLeft().name()).append("=").append(!showSecrets && entry.getLeft().isSecret() ? SECRET_REPLACEMENT : entry.getRight()).append(";");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • data/src/main/resources/kcsb.json: Language not supported
  • data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java: Evaluated as low risk
  • data/src/main/java/com/microsoft/azure/kusto/data/auth/ConnectionStringBuilder.java: Evaluated as low risk
  • data/src/main/java/com/microsoft/azure/kusto/data/auth/KcsbKeywords.java: Evaluated as low risk
  • data/src/main/java/com/microsoft/azure/kusto/data/auth/KnownKeywords.java: Evaluated as low risk
@AsafMah AsafMah merged commit 9884e0a into master Jan 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants