Extensions: Adds extensions package #4718
Open
+1,869
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
requested review from
vhvb1989,
hemarina,
weikanglim and
JeffreyCA
as code owners
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
vhvb1989
reviewed
Jan 23, 2025
| @@ -0,0 +1,65 @@ | |||
| package extensions | |||
There was a problem hiding this comment.
Suggested change
| package extensions | |
| // Copyright (c) Microsoft Corporation. All rights reserved. | |
| // Licensed under the MIT License. | |
| package extensions |
Comment on lines
+27
to
+65
| func getAbsolutePath(filePath string) (string, error) { | ||
| // Check if the path is absolute | ||
| if filepath.IsAbs(filePath) { | ||
| return filePath, nil | ||
| } | ||
|
|
||
| roots := []string{} | ||
|
|
||
| // Get the current working directory | ||
| cwd, err := os.Getwd() | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| azdConfigPath, err := config.GetUserConfigDir() | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| roots = append(roots, cwd) | ||
| roots = append(roots, azdConfigPath) | ||
|
|
||
| for _, root := range roots { | ||
| // Join the root directory with the relative path | ||
| absolutePath := filepath.Join(root, filePath) | ||
|
|
||
| // Normalize the path to handle any ".." or "." segments | ||
| absolutePath, err = filepath.Abs(absolutePath) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| if _, err := os.Stat(absolutePath); err == nil { | ||
| return absolutePath, nil | ||
| } | ||
| } | ||
|
|
||
| return "", fmt.Errorf("file '%s' was not found, %w", filePath, os.ErrNotExist) | ||
| } |
There was a problem hiding this comment.
filepath.Abs(absolutePath) is enough here. I don't think you need what you have here
| @@ -0,0 +1,9 @@ | |||
| -----BEGIN PUBLIC KEY----- | |||
There was a problem hiding this comment.
can you help me understand why we need this public keys embedded ? I saw the verifySignature() loading this public keys. Are these keys coming from the extension source you created for testing?
|
cc: @alexwolfmsft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the core components for the
azdmanagement plane ofazdextensions.Features
Enables the following features:
microsoft.azd.packextension in the sample below.Core Components
The following are the core components for the
extensionspackage.Registry
The top level schema for an
azdextension registry source.Extension Metadata
Versions
List of available extension versions
Artifact
Available artifacts by platform (os & architecture)
Extension Manager
Manages and orchestrates all the top level operations of involved in extension management:
Source Manager
Manages operations for adding & removing extension sources. This will enable having official
azdextension registry as well as support development time or internal/private extensionsExtension sources are store in
azduser configuration.Source Types:
url,fileExample Registry
{ "extensions": [ { "id": "microsoft.azd.ai", "namespace": "ai", "displayName": "AI Core Extension", "description": "This extension provides capabilities to streamline various AI development tasks. (updated)", "versions": [ { "version": "0.2.0", "usage": "azd ai \u003ccommand\u003e [options]", "examples": [ { "name": "AI setup", "description": "Initialize AI capabilities for your app.", "usage": "azd ai setup" }, { "name": "AI evaluate flow", "description": "Evaluate the flow of your AI model.", "usage": "azd ai evaluate flow" }, { "name": "AI chat", "description": "Chat with your AI model.", "usage": "azd ai chat" } ], "artifacts": { "darwin/amd64": { "checksum": { "algorithm": "sha256", "value": "e4a10bfd2ea1697ab0a091c9064eef5d5205068c2f6989074ab86f4ded56c40d" }, "entryPoint": "azd-ext-ai-darwin-amd64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.ai/0.2.0/azd-ext-ai-darwin-amd64.zip" }, "darwin/arm64": { "checksum": { "algorithm": "sha256", "value": "23ed768272d56e183ca316664f83f0d7604f9e04cd52cd386d3b4fdf73c9ee2f" }, "entryPoint": "azd-ext-ai-darwin-arm64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.ai/0.2.0/azd-ext-ai-darwin-arm64.zip" }, "linux/amd64": { "checksum": { "algorithm": "sha256", "value": "328abe9c02d7d769f548b6f815f8f2a13ad2ae18c92ee55806f070106d785ca9" }, "entryPoint": "azd-ext-ai-linux-amd64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.ai/0.2.0/azd-ext-ai-linux-amd64.zip" }, "linux/arm64": { "checksum": { "algorithm": "sha256", "value": "5a1da129cd33adb720d96aa11e63b148d1da36151bc815f8a0d6e5594f576ed7" }, "entryPoint": "azd-ext-ai-linux-arm64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.ai/0.2.0/azd-ext-ai-linux-arm64.zip" }, "windows/amd64": { "checksum": { "algorithm": "sha256", "value": "7005dd85eb58ec45841bb1b097beb7259a95a27c9063586730a91c1188190542" }, "entryPoint": "azd-ext-ai-windows-amd64.exe", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.ai/0.2.0/azd-ext-ai-windows-amd64.zip" }, "windows/arm64": { "checksum": { "algorithm": "sha256", "value": "e1b9f98f56cb8e5346bf2314ad6ede87c09a08452b33f83b673f46595adb6472" }, "entryPoint": "azd-ext-ai-windows-arm64.exe", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.ai/0.2.0/azd-ext-ai-windows-arm64.zip" } }, "entryPoint": "microsoft.azd.ai" } ], "tags": [ "ai", "extension" ] }, { "id": "microsoft.azd.test", "namespace": "test", "displayName": "Test Extension", "description": "This extension provides capabilities to streamline various test development tasks.", "versions": [ { "version": "0.0.2", "usage": "azd test \u003ccommand\u003e [options]", "examples": [ { "name": "Test", "description": "Runs tests for your apps services", "usage": "azd test [service]" } ], "artifacts": { "darwin/amd64": { "checksum": { "algorithm": "sha256", "value": "b79d94795c04b967b72802872fe7a8b0865da90cb2d4f35f54265308a0675157" }, "entryPoint": "azd-ext-test-darwin-amd64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.test/0.0.2/azd-ext-test-darwin-amd64.zip" }, "darwin/arm64": { "checksum": { "algorithm": "sha256", "value": "3b66d9c5c2f418810fc8ce6737b2943abae1877ee9537f11e35e6e96a1ee8774" }, "entryPoint": "azd-ext-test-darwin-arm64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.test/0.0.2/azd-ext-test-darwin-arm64.zip" }, "linux/amd64": { "checksum": { "algorithm": "sha256", "value": "b54557ddb563ad886b9b41a28f5e1136bae1f1d94955f19a98f8bddc0c619452" }, "entryPoint": "azd-ext-test-linux-amd64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.test/0.0.2/azd-ext-test-linux-amd64.zip" }, "linux/arm64": { "checksum": { "algorithm": "sha256", "value": "41935ef5017e76085bff93f193f0cb58be99a044455c711e3eb811d61364b0d6" }, "entryPoint": "azd-ext-test-linux-arm64", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.test/0.0.2/azd-ext-test-linux-arm64.zip" }, "windows/amd64": { "checksum": { "algorithm": "sha256", "value": "9767630aed98323b1fe782ee1f3e9d7a83b8b670efadc946ac3bdb57776a1352" }, "entryPoint": "azd-ext-test-windows-amd64.exe", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.test/0.0.2/azd-ext-test-windows-amd64.zip" }, "windows/arm64": { "checksum": { "algorithm": "sha256", "value": "66eec18597c4ce1e170ab6043572a8eb696b611ab0f3915deb7d33648d9f1efb" }, "entryPoint": "azd-ext-test-windows-arm64.exe", "url": "https://github.com/wbreza/azd-extensions/raw/main/registry/extensions/microsoft.azd.test/0.0.2/azd-ext-test-windows-arm64.zip" } } } ], "tags": [ "test", "extension" ] }, { "id": "microsoft.azd.pack", "displayName": "azd extension pack", "description": "This extension pack provides capabilities to streamline various development tasks.", "versions": [ { "version": "0.0.1", "usage": "", "examples": [ { "name": "AI setup", "description": "Initialize AI capabilities for your app.", "usage": "azd ai setup" }, { "name": "Test", "description": "Runs tests for your apps services", "usage": "azd test [service]" } ], "dependencies": [ { "id": "microsoft.azd.ai", "version": "0.2.0" }, { "id": "microsoft.azd.test", "version": "0.0.2" } ] } ], "tags": [ "pack" ] } ], "signature": "o8GdoLhIinhO5jixbjJmNBkBSU6WvplKMOFXmDsy54Q/fbixHKVWMu6Q39/pZ7SxBVHuLjfnaO4uq7D2AK1lV0VJyVDTBGVBQGtyMxW6orWBoh1MAcrhaUavAfPQpctf8vj19tsFmzP9XPRg3hv5Ws7Rq9Jbo5qxAP0Tu4CAwiaKN2vh3NO7eS8xJ7tzvnflO/3nSOKM+D0g1PJLPLP6x7lJj9V7esBN4DuGjMyo2VVGK4j1zFPrhtjgEhC6IoXfY+9HKXAbNe9enczrVArr0X7ztFKY6+G2VbB1mSjAwt18SFnjqJVnGkO4ZkMWTvH6DHb5bT1csJy4ZIT8efsCBg==" }