[Hotfix] CrossRegionHedging: Fixes NullReference Exception Bug #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Pull Request Template
## Description
Adds support to use hedging on write requests for multimaster accounts.
Note that this does come with the caveat that there will be more 409
errors thrown by the SDK. This is expected and applications that adapt
this feature should be prepared to handle these exceptions.
This feature will also be an opt in feature for Availability Strategies
and users will need to especially specify that in the availability
strategy definition.
```
ItemRequestOptions requestOptions = new ItemRequestOptions
{
AvailabilityStrategy = new CrossRegionHedgingAvailabilityStrategy(
threshold: TimeSpan.FromMilliseconds(100),
thresholdStep: TimeSpan.FromMilliseconds(50),
multiMasterWritesEnabled: true)
};
```
## Type of change
Please delete options that are not relevant.
- [] New feature (non-breaking change which adds functionality)
## Closing issues
To automatically close an issue: closes #4457
---------
Co-authored-by: Fabian Meiswinkel <[email protected]>
Co-authored-by: Kevin Pilch <[email protected]>
# Pull Request Template ## Description This change is to fix CosmosNullReferenceException that happens when a client passes a CancellationToken along with the request. Please see(#4737) for more information. ## Type of change Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #4737 --------- Co-authored-by: Arooshi Avasthy <[email protected]> Co-authored-by: Kiran Kumar Kolli <[email protected]> Co-authored-by: Nalu Tripician <[email protected]>
kundadebdatta
requested review from
a team,
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
NaluTripician
approved these changes
Jan 8, 2025
ananth7592
approved these changes
Jan 8, 2025
kirankumarkolli
approved these changes
Jan 8, 2025
microsoft-github-policy-service
bot
merged commit ee83a58
into
releases/3.46.1
25 of 26 checks passed
microsoft-github-policy-service
bot
deleted the
users/kundadebdatta/hotfix/3.46.1_more
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR cherry-picks the following commits:
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber