Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Samples: Adds samples for Container.IsFeedRangePartOfAsync #4782
base: master
Are you sure you want to change the base?
[Internal] Samples: Adds samples for Container.IsFeedRangePartOfAsync #4782
Changes from 3 commits
42bd693
6066397
03d7832
48ac1fd
44b1ebc
56c8d99
e0c3e1b
58d6e4c
ee8ec2c
28e509d
abebdf8
0b63ce4
42ee4b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ideal use-case application will not set random FeedRange but gets it from one of the client APIs.
So idea is to have a scenario E2E such that the FeedRange is read from client API and then feed into IsFeedRangePartOfAsync API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirankumarkolli I disagree. I would have to set up a sample that mimics how a specific customer wants to use this. I am showcasing the new capability, not trying to reproduce every variation someone wants to use it.
Ex. Create a ChangeFeedProcessor, read FeedRange from the ChangeFeedContext, read FeedRanges (bookmarks) from another Container and validate using IsFeedRangePartOfAsync. This is too much for a sample that is supposed to be agnostic and totally disconnected from one customer's use case scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new direction for sample.