fix: issue dhcp request on windows secondary interfaces #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebancams
reviewed
Oct 4, 2024
estebancams
reviewed
Oct 5, 2024
estebancams
reviewed
Oct 6, 2024
timraymond
reviewed
Oct 7, 2024
…t existing cni code include last error cause when cooldown function errors (discuss) for compatability use durations instead of millis correct usage of number retries vs number of runs create helper function for retrying in transparent vlan mode create wrapper method that makes all passed in errors temporary (retriable) errors
QxBytes
force-pushed
the
alew/dhcp-win
branch
2 times, most recently
from
59225e4 to
a10f0df
Compare
timraymond
reviewed
Oct 9, 2024
timraymond
approved these changes
Oct 10, 2024
estebancams
approved these changes
Oct 14, 2024
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
@QxBytes stalebot is targeting this PR again. Anything else needed here? |
|
there is no repro to test this fix on at the moment |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We need to issue a dhcp request to the host in order to create a mapping for the secondary interface. The mapping allows for us to query the azure dns server on the secondary interface. The dhcp discover request occurs before the interface has the intended ip or is moved into the container namespace, but it does have an apipa autoconfigured ip. The auto assigned ip allows us to set the source ip of the packet so that the dhcp packet goes out on the interface that we want. We assume the interface always gets an auto configured ip. Then, once cni completes, we expect that secondary interface to be moved into the container.
Adds validation for nwCfg.Master since we issue exec commands with the field, so ensure this validation does not break anything else.
Reorganizes code into dhcp linux, windows and common.
Reorganizes retry logic into separate package
Confirm that we only run this code if we are on swiftv2 windows (is the nic type condition correct?). Confirmed yes.
Tested:
Limitations:
Issue Fixed:
Requirements:
Notes:
Related to #2989