Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Added Blank Unit Test Icon Option to Designer View #6462

Open
wants to merge 2 commits into
base: developer/UnitTestCodeful
Choose a base branch
from

Conversation

samikay101
Copy link
Contributor

Work Item Link

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

Currently, the "Save Blank Unit Test" button is implemented in the Monitoring View. This functionality is limited in scope and does not align well with the user workflow of designing Logic Apps.

New Behavior

The "Save Blank Unit Test" button has been moved to the Designer View, allowing users to generate blank unit tests directly within the design process. This improves usability and better integrates the feature into the Logic Apps design workflow.

Key changes:

  • Added a SaveBlank button to the designerItems command bar in the Designer View.
  • Button retains the same functionality as before, including telemetry logging and blank unit test saving logic.

Impact of Change

  • This is a breaking change.

This change does not introduce breaking changes. It relocates an existing feature for improved usability.

Test Plan

  • Verified that the SaveBlank button appears in the Designer View command bar.
  • Tested button functionality:
    • Confirmed it logs telemetry for unit test generation.
    • Ensured that clicking the button triggers the correct backend API for blank unit test generation.
  • Verified that the button no longer appears in the Monitoring View.
  • Unit tests were updated to ensure coverage for the Designer View changes.
  • Performed manual testing in both single-root and multi-root workspaces to validate behavior consistency.

@samikay101 samikay101 requested a review from hartra344 as a code owner January 24, 2025 00:04
@@ -176,8 +181,8 @@ export const DesignerCommandBar: React.FC<DesignerCommandBarProps> = ({
description: 'Button text for unit test asssertions',
}),
UNIT_TEST_SAVE_BLANK: intl.formatMessage({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: can you update the name of the UNIT_TEST_SAVE_BLANK constant as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants