-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Logic App and Workflows As Menu Items #6310
base: main
Are you sure you want to change the base?
feat(vscode): Logic App and Workflows As Menu Items #6310
Conversation
… items. Removed ability to create logic app outside of a workspace. Refactored to utilize common methods and reduce duplication
…e is opened for full functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (15)
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createLogicApp/ScriptProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ProjectCodeCreateStepBase.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ExistingWorkspaceStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createNewProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createNewCodeProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetWorkspaceName.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetWorkspaceSettings.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/WorkflowCodeProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/InvokeFunctionProjectSetup.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/OpenFolderStepCodeProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/main.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ProjectCreateStepBase.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/NewCodeProjectTypeStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ScriptProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetLogicAppNameStep.ts: Evaluated as low risk
…nction method names inside a workspace, moved convert to workspace
…ions.json file, corrected path to create .vscode folder, and updated OpenFolder to not add the .code-workspace file to the workspace folders.
…schema type in isLogicAppProject. Improved prompt to only display the folders that contain a logic app project, not all folders in the workspace.
… logic apps with possibly the same workflow names
…if the menu was initiated outside of highlighted logic app in the workspace
…rianmsft/LogicAppsUX into logic_app_and_workflow_menu
… trigger if a logic app project is not found in the workspace
…if the project is not in a workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 21 out of 36 changed files in this pull request and generated no comments.
Files not reviewed (15)
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ProjectCodeCreateStepBase.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createLogicApp/ScriptProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createLogicApp/initLogicAppCodeProjectVScode/InitCodeProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/FunctionConfigFile.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ProjectCreateStepBase.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createNewCodeProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/NewCodeProjectTypeStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/InvokeFunctionProjectSetup.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/WorkflowCodeProjectCreateStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/OpenFolderStepCodeProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewProject/createNewProject.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetLogicAppNameStep.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/SetWorkspaceName.ts: Evaluated as low risk
- apps/vs-code-designer/src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/setMethodName.ts: Evaluated as low risk
...vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ConvertToWorkspace.ts
Outdated
Show resolved
Hide resolved
...vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ConvertToWorkspace.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/generateDeploymentScripts/generateDeploymentScripts.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewProject/createNewProject.ts
Outdated
Show resolved
Hide resolved
...src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/setMethodName.ts
Outdated
Show resolved
Hide resolved
...nds/createNewCodeProject/createCodeProjectSteps/createFunction/InvokeFunctionProjectSetup.ts
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/generateDeploymentScripts/generateDeploymentScripts.ts
Show resolved
Hide resolved
...vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ConvertToWorkspace.ts
Outdated
Show resolved
Hide resolved
...vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ConvertToWorkspace.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added feedback.
@lambrianmsft & @ccastrotrejo: When is the plan to make these changes public? I recently updated our doc about creating Standard workflows with Visual Studio Code. This PR makes substantial changes around behavior and UX options. Thanks! |
...src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/setMethodName.ts
Outdated
Show resolved
Hide resolved
...src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/setMethodName.ts
Outdated
Show resolved
Hide resolved
...src/app/commands/createNewCodeProject/createCodeProjectSteps/createFunction/setMethodName.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/workflows/switchToDotnetProject.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/workflows/switchToDotnetProject.ts
Outdated
Show resolved
Hide resolved
...vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/ConvertToWorkspace.ts
Outdated
Show resolved
Hide resolved
Hi @ecfan we are targeting the release of this update by the first two weeks of Feb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know when you're done integrating the suggestions. Thanks!
…tProject.ts Co-authored-by: Esther Fan <[email protected]>
…deProjectBase/ConvertToWorkspace.ts Co-authored-by: Esther Fan <[email protected]>
…tProject.ts Co-authored-by: Esther Fan <[email protected]>
…eateCodeProjectSteps/createFunction/setMethodName.ts Co-authored-by: Esther Fan <[email protected]>
…eateCodeProjectSteps/createFunction/setMethodName.ts Co-authored-by: Esther Fan <[email protected]>
…eateCodeProjectSteps/createFunction/setMethodName.ts Co-authored-by: Esther Fan <[email protected]>
…deProjectBase/ConvertToWorkspace.ts Co-authored-by: Esther Fan <[email protected]>
…deProjectBase/ConvertToWorkspace.ts Co-authored-by: Esther Fan <[email protected]>
Right-click Menu Options:
Logic App Project Outside Workspace:
Workspace Requirements:
Convert to NuGet Project:
Requirement Checklist
Type of Change
Current Behavior
Currently customers can create logic app projects without a workspace as well as add new logic app projects and workflows by going to the Azure icon and clicking on the Logic Apps icon as shown. Custom code and rules engine projects have the logic app created as LogicApp and the functions under Function folder as default.
New Behavior
Customers will now be unable to create logic apps outside of a workspace. Customers will now be required to create a logic app workspace that holds their logic app project. Customers will now be able to add new logic app projects and workflows to their workspace by using the right click menu and selecting the appropriate option.
Custom code and rules engine projects now have a logic app name prompt instead of defaulting to LogicApp and the Functions folder is now removed and renamed to the name of the function the user created.
Impact of Change
See the new behavior section.
Screenshots or Videos (if applicable)