Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Designer): Keyboard focus move outside of 'Insert dynamic content' dialog #6303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Elaina-Lee
Copy link
Contributor

Requirement Checklist

  • The commit message follows our guidelines

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

Keyboard focus move outside of the 'Insert dynamic content' dialog when navigating using keyboard

New Behavior

Keyboard stays within the dialog unless 'esc' key is pressed. When using mouse to navigate, it can still exit the focus when clicked outside of dialog.

Impact of Change

  • This is a breaking change.

Screenshots or Videos (if applicable)

Recording.2024-12-23.002608.mp4

Copy link
Contributor

@Eric-B-Wu Eric-B-Wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can look to trap focus in the tokenpicker, but it should be done in another way. With FocusTrapCallout, when users blur the tokenpicker, the focus always goes back to the editor which opened that tokenpicker. For example, if the user clicks another editor with the tokenpicker open, the focus isn't on the new editor, but rather the original editor that opened the tokenpicker

@Eric-B-Wu Eric-B-Wu added the a11y Accessibility label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants