-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Custom Code Support in VSCode #6251
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some unit tests for this?
@@ -309,6 +296,10 @@ const ParameterSection = ({ | |||
} | |||
}; | |||
|
|||
const fileNameChange = (originalFileName: string, fileName: string): void => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: can this be a useCallback?
} | ||
const initialValue = editorOptions?.language && customCodeEditor ? [createLiteralValueSegment(customCodeData)] : value; | ||
const language = editorOptions.language ?? EditorLanguage.javascript; | ||
console.log(editorViewModel); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: console.log
|
||
return ( | ||
<div className="msla-custom-code-editor-fileName"> | ||
<input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the input from fluent react?
Creating Powershell actions and uploading AppFiles
deletion
rename(new)