fix(designer-ui): Prevent certain malicious HTML from executing in raw HTML editor #4554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I have tests for this, but they will be added in a follow-up PR once this fix rolls out.
[Targeting 2.X and 3.X versions as needed. Main PR is #4553.]
Bug fix [security]
Certain maliciously crafted payloads, if provided into the raw HTML editor, may permit XSS attacks. Please ping me directly if there are questions about specifics.
Use of
DOMParser
instead ofdocument.createElement
prevents malicious HTML from being executed.No
Not included as this is a security fix.