-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Resource Provider Namespace to Abbreviation #161
base: main
Are you sure you want to change the base?
Conversation
* Microsoft.DesktopVirtualization/hostPools -> vdpool * Microsoft.DesktopVirtualization/applicationGroups -> vdag * Microsoft.DesktopVirtualization/workspaces -> vdws
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work. Please test before submitting PRs :).
You changed the name of the resource providers, not the name of the deployed resources.
It should be fixed now, I apologize for the oversight, and thanks for the feedback! I misinterpreted the docs and assumed tests passed with the PR checkmark for CI/CD. Code has been validated using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry, but this is not what I meant. We want the Azure resource names to align with the abbreviation guidance provided at https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations. You changed the symbolic names of the resources in Bicep but this does not affect the Azure resource names.
resource vdpool 'Microsoft.DesktopVirtualization/hostPools@2023-09-05' = {
name: replace(namingStructure, '{rtype}', 'vdpool') // Place to Change
location: location
properties: {
hostPoolType: 'Pooled'
loadBalancerType: 'BreadthFirst'
preferredAppGroupType: deployDesktopAppGroup ? 'Desktop' : 'RailApplications'
customRdpProperty: customRdpProperty
registrationInfo: {
registrationTokenOperation: 'Update'
expirationTime: dateTimeAdd(deploymentTime, 'PT5H')
}
maxSessionLimit: 25
publicNetworkAccess: usePrivateLinkForHostPool ? 'EnabledForClientsOnly' : 'Enabled'
// LATER: Add Start VM On Connect configuration (role config!)
}
tags: tags
} Sorry for the confusions, so only the name of the deployed resource should be changed to the abbreviation like the example above correct? Or would it be the below? resource hostPools 'Microsoft.DesktopVirtualization/hostPools@2023-09-05' = {
name: replace(namingStructure, '{rtype}', 'vdpool') // Place to Change
location: location
properties: {
hostPoolType: 'Pooled'
loadBalancerType: 'BreadthFirst'
preferredAppGroupType: deployDesktopAppGroup ? 'Desktop' : 'RailApplications'
customRdpProperty: customRdpProperty
registrationInfo: {
registrationTokenOperation: 'Update'
expirationTime: dateTimeAdd(deploymentTime, 'PT5H')
}
maxSessionLimit: 25
publicNetworkAccess: usePrivateLinkForHostPool ? 'EnabledForClientsOnly' : 'Enabled'
// LATER: Add Start VM On Connect configuration (role config!)
}
tags: tags
} |
#157
Microsoft.DesktopVirtualization/hostPools -> vdpool
Microsoft.DesktopVirtualization/applicationGroups -> vdag
Microsoft.DesktopVirtualization/workspaces -> vdws