Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a PowerShell script to delete an entire spoke deployment #158

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Provide a PowerShell script to delete an entire spoke deployment #158

wants to merge 21 commits into from

Conversation

SvenAelterman
Copy link
Collaborator

No description provided.

@SvenAelterman SvenAelterman linked an issue Dec 27, 2024 that may be closed by this pull request
Provide a PowerShell script to delete an entire spoke deployment #155
Open
@SvenAelterman
Remove the disconnected peering on the research hub network
57f11d4
@SvenAelterman
Add TenantId parameter and use it to prevent warnings about other ten…
ddf95de 
…ants
@SvenAelterman
Perform error handling
71b1698 
Switch back to original subscription after script runs
@SvenAelterman
Ask for confirmation before deleting
025c113 
Support for `-Force` switch
Improve default value for Tenant parameter
Enhanced verbose output
@SvenAelterman
Use Invoke-AzRestMethod
111f8b0 
Add Tenant parameter and don't display output of Select-AzSubscription
@SvenAelterman
Fix REST method parameters for DELETE operation
f815f4d
@SvenAelterman
Update required modules
48c03de 
PS linting
@SvenAelterman
Prevent resource lock deletes from showing output
858e127
@SvenAelterman
Update comment-based help
95ec989
@SvenAelterman
Add PowerShell module docs generated by platyPS
111c85d
@SvenAelterman
Update metadata and inline documentation
51069cc
@SvenAelterman
Add PSDocs template and auto-generated doc for research spoke template
307a90d
@SvenAelterman
Experimental: wrapper code to generate PS and ARM template docs
9c1d437
@SvenAelterman SvenAelterman marked this pull request as ready for review December 27, 2024 20:30
@SvenAelterman
Copy link
Collaborator Author

SvenAelterman commented Jan 2, 2025 •
edited
Loading

TODO:

  • Move retrieving hub virtual network ID to the same lines where the rest of the param file is read
  • Check if RSV immutability state is locked before attempting any removals. Consider allowing -Force to override this.

@JackStuart JackStuart mentioned this pull request Jan 6, 2025
Open
@SvenAelterman
Ensure links to params work in generated documentation.
f8fd646 
Add descriptions to all research spoke parameters and outputs to help with documentation generation.
Remove dead code.
@SvenAelterman
Fix typo in description
5feaa68
@vbalbarin
Copy link
Contributor

The code looks good and works. My only comment is that the indexing of the positional parameters should start at 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbalbarin vbalbarin Awaiting requested review from vbalbarin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a PowerShell script to delete an entire spoke deployment
2 participants
@SvenAelterman @vbalbarin