-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: December general quality updates #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigosantosms
requested a deployment
to
BuildObject
December 18, 2024 04:59 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
Azure
December 18, 2024 04:59 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
BuildObject
December 18, 2024 05:01 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
Azure
December 18, 2024 05:01 — with
GitHub Actions
Waiting
rodrigosantosms
temporarily deployed
to
BuildObject
December 18, 2024 05:01 — with
GitHub Actions
Inactive
rodrigosantosms
requested a deployment
to
Azure
December 18, 2024 05:01 — with
GitHub Actions
Waiting
kpoineal
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Claudio-Merola
approved these changes
Dec 18, 2024
rodrigosantosms
requested a deployment
to
BuildObject
December 18, 2024 20:35 — with
GitHub Actions
Waiting
rodrigosantosms
had a problem deploying
to
Azure
December 18, 2024 20:35 — with
GitHub Actions
Failure
rodrigosantosms
requested a deployment
to
BuildObject
December 18, 2024 21:35 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
Azure
December 18, 2024 21:35 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
Azure
December 19, 2024 16:53 — with
GitHub Actions
Waiting
rodrigosantosms
temporarily deployed
to
BuildObject
December 19, 2024 16:53 — with
GitHub Actions
Inactive
rodrigosantosms
requested a deployment
to
Azure
December 19, 2024 18:44 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
BuildObject
December 19, 2024 18:44 — with
GitHub Actions
Waiting
rodrigosantosms
temporarily deployed
to
BuildObject
December 19, 2024 18:46 — with
GitHub Actions
Inactive
rodrigosantosms
requested a deployment
to
Azure
December 19, 2024 18:46 — with
GitHub Actions
Waiting
maurojasmsft
approved these changes
Dec 19, 2024
oZakari
added
the
Needs: Attention from aprl-maintainers 👋
Needs attention from aprl-admins GitHub team.
label
Dec 20, 2024
rodrigosantosms
requested a deployment
to
Azure
December 20, 2024 16:22 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
BuildObject
December 20, 2024 16:22 — with
GitHub Actions
Waiting
rodrigosantosms
requested a deployment
to
Azure
December 20, 2024 16:29 — with
GitHub Actions
Waiting
oZakari
changed the title
fix: December quality updates
fix: December general quality updates
Dec 20, 2024
oZakari
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug 🐞
Something isn't working
Needs: Attention from aprl-maintainers 👋
Needs attention from aprl-admins GitHub team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Updating, Removing and Adding new recommendations. The removals from SQL and MySQL are aligned with PG.
All Zone redundancy recommendations must be High
Only ExpressRoute monitoring can be High, all other services should be Medium
VPN is not considered a Mission Critical option, and then recommendations now have a tag informing that
Adding new queries for Network Watcher and other services.
Updating the list of ResourceTypes in scope of Waras.