Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updating the Machine Learning Services Recommendations regards to quota #580

Merged
merged 9 commits into from
Dec 18, 2024
Merged

docs: Updating the Machine Learning Services Recommendations regards to quota #580

merged 9 commits into from
Dec 18, 2024

Conversation

chinthakaru
Copy link
Contributor

@chinthakaru chinthakaru commented Dec 17, 2024 •
edited
Loading

Updating the Machine Learning Services Recommendations regards to quota management

Overview/Summary

Related Issues/Work Items

Breaking Changes

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@chinthakaru chinthakaru marked this pull request as ready for review December 17, 2024 11:45
@Copilot Copilot bot review requested due to automatic review settings December 17, 2024 11:45
@chinthakaru chinthakaru requested a review from a team as a code owner December 17, 2024 11:45
Copilot
Copilot AI reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

azure-resources/MachineLearningServices/workspaces/recommendations.yaml Outdated Show resolved Hide resolved
azure-resources/MachineLearningServices/workspaces/recommendations.yaml Outdated Show resolved Hide resolved
@oZakari
Copy link
Collaborator

oZakari commented Dec 17, 2024

Hi @chinthakaru, please create the associated KQL files for the new recommendations.

@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Dec 18, 2024
@chinthakaru
Copy link
Contributor Author

Hi @chinthakaru, please create the associated KQL files for the new recommendations.

Done.

oZakari
oZakari approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari requested a review from ejhenry December 18, 2024 01:55
@oZakari oZakari added the Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. label Dec 18, 2024
ejhenry
ejhenry approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry merged commit 0cd7522 into Azure:main Dec 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@ejhenry ejhenry ejhenry approved these changes

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinthakaru @oZakari @ejhenry