Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reccomendation cross-region failover for Private DNS Resolver #578

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

lvlindv
Copy link
Contributor

@lvlindv lvlindv commented Dec 16, 2024

Overview/Summary

Created reccomendation and kql query for Private dns resolver

Related Issues/Work Items

https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38509/

As part of this pull request I have

  • [x ] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ x] Checked for duplicate Pull Requests
  • [ x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [ x] Ensured PR tests are passing
  • [ x] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • [ x] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings December 16, 2024 15:23
@lvlindv lvlindv requested review from a team as code owners December 16, 2024 15:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

azure-resources/Network/dnsResolvers/recommendations.yaml:1

  • The word 'reccomendation' is misspelled; it should be 'recommendation'.
- description: Configure AZs and/or cross-region failover for Private DNS Resolver
@lvlindv lvlindv changed the title reccomendation and kql privatednsresolver docs: reccomendation and kql privatednsresolver Dec 16, 2024
@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Area: Resource Graph Query(s) #️⃣ Related to ARG queries Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Dec 16, 2024
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I do not believe there is anything to recommend. Private DNS Resolver cannot be manually configured to use (or not use) multiple AZs, it will automatically use multiple AZs when available.

For multi-region, there is no checkbox, or configuration toggle to enable for multi-region. Multi-region requires many configuration steps across different Azure resources that are context dependent on the customer environment. I am not confident a KQL query could be written to evaluate if those context dependent configuration steps have been done. Remediation guidance would equally challenging to write. Generally multi-region/DR approaches are covered by WAF guidance unless a resource has specific configurable multi-region options.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Dec 18, 2024
@lvlindv lvlindv changed the title docs: reccomendation and kql privatednsresolver docs: reccomendation cross-region failover for Private DNS Resolver Dec 18, 2024
@oZakari oZakari added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Dec 18, 2024
recommendation changed to Setup DNS cross-region failover using Azure DNS private resolvers
kql file:  // under-development
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Dec 19, 2024
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari added the Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team label Dec 20, 2024
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for working on this with the feedback we had!

@ejhenry ejhenry merged commit e36978c into Azure:main Jan 7, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants