-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reccomendation cross-region failover for Private DNS Resolver #578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
azure-resources/Network/dnsResolvers/recommendations.yaml:1
- The word 'reccomendation' is misspelled; it should be 'recommendation'.
- description: Configure AZs and/or cross-region failover for Private DNS Resolver
azure-resources/Network/dnsResolvers/kql/bdd38c02-96bf-4d4e-a636-293729463f3d.kql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I do not believe there is anything to recommend. Private DNS Resolver cannot be manually configured to use (or not use) multiple AZs, it will automatically use multiple AZs when available.
For multi-region, there is no checkbox, or configuration toggle to enable for multi-region. Multi-region requires many configuration steps across different Azure resources that are context dependent on the customer environment. I am not confident a KQL query could be written to evaluate if those context dependent configuration steps have been done. Remediation guidance would equally challenging to write. Generally multi-region/DR approaches are covered by WAF guidance unless a resource has specific configurable multi-region options.
…vate DNS Resolver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you for working on this with the feedback we had!
Overview/Summary
Created reccomendation and kql query for Private dns resolver
Related Issues/Work Items
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38509/
As part of this pull request I have
main
branch