Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update APRL for vWAN recommendations #566

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

docs: update APRL for vWAN recommendations #566

wants to merge 18 commits into from

Conversation

maurojasmsft
Copy link
Contributor

Overview/Summary

Adding ARG queries for APRL recommendations vWAN.

  • Monitor health for v-Hub's ExpressRoute gateway
    • Monitor health for v-Hubs
    • Monitor gateway for Site-to-site v-Hub's VPN gateway
    • Monitor health for v-Hub's Point-to-Site VPN gateways

Added new recommendations and KQL queries

  • Configure diverse VPN Site links to different VPN concentrators on-premises.
    • Avoid using ExpressRoute circuits for VNet to VNet communication
    • Migrate from Basic to Standard Virtual WAN

Related Issues/Work Items

Breaking Changes

  1. Replace me
  2. Replace me

As part of this pull request I have

  • [x ] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [x ] Checked for duplicate Pull Requests
  • [x ] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [x ] Ensured PR tests are passing
  • [x ] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • [x ] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Mauricio Rojas Martinez and others added 11 commits October 7, 2024 15:50
Added: - Establish a tunnel between the on-premises device(s) and eac…
83f2a7a 
…h VPN gateway instance

Added: Avoid using ExpressRoute circuits for VNet to VNet communication
Changed: P2S, VPN to // cannot-be-validated-with-arg
Merge branch 'aprlvwanv2' of https://github.com/maurojasmsft/Azure-Pr…
66232fd 
…oactive-Resiliency-Library-v2 into aprlvwanv2
@maurojasmsft
Merge branch 'Azure:main' into aprlvwanv2
5610d78
Added: vWAN from Basic to Standard recommendation
4a8e7a8
Merge branch 'aprlvwanv2' of https://github.com/maurojasmsft/Azure-Pr…
3f72769 
…oactive-Resiliency-Library-v2 into aprlvwanv2
Added KQL queries
631f93a
Added KQL queries for ExR GW, vhub GW, VPN GW Monitoring
d820a9b
corrected KQL for VPN GW on vWAN
a27ce3b
added Vnet to Vnet No Virtual Wan traffic KQL query and changed recom…
385dd3b 
…mendation to ExR Gateways
Added queries for P2S monitoring
c525006
@maurojasmsft
Merge branch 'Azure:main' into aprlvwanv2
5500d54
@maurojasmsft maurojasmsft requested review from a team as code owners December 11, 2024 15:41
ehaslett
ehaslett previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one comment I made, LGTM

@maurojasmsft maurojasmsft changed the title Aprlvwanv2 docs: update APRL for vWAN recommendations Dec 11, 2024
DaFitRobsta
DaFitRobsta previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@DaFitRobsta DaFitRobsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the output from the KQL to follow the guidelines outlined here:
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/contributing/create-content/create-arg-queries/
Then it will LGTM 👍.

@maurojasmsft
Copy link
Contributor Author

@DaFitRobsta modified

@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Area: Resource Graph Query(s) #️⃣ Related to ARG queries labels Dec 13, 2024
oZakari
oZakari approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @maurojasmsft!

@oZakari oZakari added the Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team label Dec 16, 2024
rodrigosantosms

This comment was marked as outdated.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigosantosms rodrigosantosms rodrigosantosms requested changes

@oZakari oZakari oZakari approved these changes

@ehaslett ehaslett Awaiting requested review from ehaslett

@DaFitRobsta DaFitRobsta Awaiting requested review from DaFitRobsta

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maurojasmsft @rodrigosantosms @oZakari @DaFitRobsta @ehaslett @ejhenry